Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend unstructured composed package with additional methods #518

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Aug 14, 2023

Description of your changes

This PR adds additional methods to the unstructured composed package.
These methods will be consumed by the Usage implementation as suggested here.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Consume this PR on top of crossplane/crossplane#4444 and run:

make e2e E2E_TEST_FLAGS="-test.v --test-suite usage"

Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Contributor

@bobh66 bobh66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turkenh turkenh merged commit fcbb2cd into crossplane:master Aug 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants