feat(composite): Add support for EnvironmentConfigs #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
MisterMX
force-pushed
the
composite-environment
branch
from
75c32d0
to
af8e76e
Compare
MisterMX
changed the title
MisterMX
changed the title
MisterMX
force-pushed
the
composite-environment
branch
from
af8e76e
to
dfd4687
Compare
3 tasks
negz
reviewed
Sep 7, 2022
Comment on lines
+234
to
+235
| // TODO(negz): Ask muvaf to explain what this is working around. :) | ||
| // TODO(muvaf): temporary workaround. |
There was a problem hiding this comment.
I think @muvaf is on vacation, but I'd still love to know what this is doing. 😄
There was a problem hiding this comment.
I think it was about having empty elements in the array causing problem since the element would be omitted but I'm not 100% sure.
negz
approved these changes
Sep 7, 2022
ytsarev
reviewed
Nov 9, 2022
| } | ||
| filtered = append(filtered, ref) | ||
| } | ||
| _ = fieldpath.Pave(c.Object).SetValue("spec.resourceRefs", filtered) |
There was a problem hiding this comment.
Shouldn't it set spec.environmentConfigRefs here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds interface and mock functions to allow storing references to EnvironmentConfigs in XRs (
spec.environmentConfigRefs).Ref. design document crossplane/crossplane#3008.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
n.A.