package.parser: make Or linter work with arbitrary number of linters #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of only two Signed-off-by: Muvaffak Onus <me@muvaf.com>
muvaf
commented
Mar 7, 2022
| return errors.New(errNilLinterFn) | ||
| } | ||
| err := l(o) | ||
| if err == nil { |
There was a problem hiding this comment.
This is a behavioral difference that if any of the linters pass, we don't execute the next ones at all, which is I believe more in-line with how OR behavior is implemented in general.
negz
approved these changes
Mar 8, 2022
pkg/parser/linter.go
Outdated
| } | ||
| return errors.Errorf(errOrFmt, aErr, bErr) | ||
| return errors.Errorf(errOrFmt, strings.TrimSuffix(errSet, ", ")) |
There was a problem hiding this comment.
Nit: Could you just build a slice of strings then join them, to avoid needing to trim?
There was a problem hiding this comment.
Ah I knew there was a better way to do this, thanks!
… the flow simpler Signed-off-by: Muvaffak Onus <me@muvaf.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We need this in provider linter where we need to allow three distinct types,
CustomResourceDefinition,ValidatingWebhookConfigurationandMutatingWebhookConfiguration.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests. No breaking change in the interface only the format of the printed error is different now.