Skip to content

Commit

Permalink
Merge pull request #291 from negz/error
Browse files Browse the repository at this point in the history
Add an `errors` package with a similar API to `github.com/pkg/errors`
  • Loading branch information
negz committed Sep 13, 2021
2 parents 9779b31 + 3aa81c4 commit 6a7a44a
Show file tree
Hide file tree
Showing 34 changed files with 294 additions and 36 deletions.
3 changes: 2 additions & 1 deletion apis/common/v1/condition_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ import (
"testing"

"github.com/google/go-cmp/cmp"
"github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

"github.com/crossplane/crossplane-runtime/pkg/errors"
)

func TestConditionEqual(t *testing.T) {
Expand Down
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ require (
github.com/google/go-cmp v0.5.6
github.com/hashicorp/go-getter v1.4.0
github.com/imdario/mergo v0.3.12
github.com/pkg/errors v0.9.1
github.com/spf13/afero v1.6.0
golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac
k8s.io/api v0.21.3
Expand Down
3 changes: 2 additions & 1 deletion pkg/controller/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"context"
"sync"

"github.com/pkg/errors"
"k8s.io/client-go/rest"
"sigs.k8s.io/controller-runtime/pkg/cache"
"sigs.k8s.io/controller-runtime/pkg/client"
Expand All @@ -30,6 +29,8 @@ import (
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/predicate"
"sigs.k8s.io/controller-runtime/pkg/source"

"github.com/crossplane/crossplane-runtime/pkg/errors"
)

// Error strings
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
"time"

"github.com/google/go-cmp/cmp"
"github.com/pkg/errors"
"k8s.io/client-go/rest"
"sigs.k8s.io/controller-runtime/pkg/cache"
"sigs.k8s.io/controller-runtime/pkg/controller"
Expand All @@ -31,6 +30,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/predicate"
"sigs.k8s.io/controller-runtime/pkg/source"

"github.com/crossplane/crossplane-runtime/pkg/errors"
"github.com/crossplane/crossplane-runtime/pkg/resource/fake"
"github.com/crossplane/crossplane-runtime/pkg/test"
)
Expand Down
128 changes: 128 additions & 0 deletions pkg/errors/errors.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
/*
Copyright 2021 The Crossplane Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

// Package errors is a github.com/pkg/errors compatible API for native errors.
// It includes only the subset of the github.com/pkg/errors API that is used by
// the Crossplane project.
package errors

import (
"errors"
"fmt"
)

// New returns an error that formats as the given text. Each call to New returns
// a distinct error value even if the text is identical.
func New(text string) error { return errors.New(text) }

// Is reports whether any error in err's chain matches target.
//
// The chain consists of err itself followed by the sequence of errors obtained
// by repeatedly calling Unwrap.
//
// An error is considered to match a target if it is equal to that target or if
// it implements a method Is(error) bool such that Is(target) returns true.
//
// An error type might provide an Is method so it can be treated as equivalent
// to an existing error. For example, if MyError defines
//
// func (m MyError) Is(target error) bool { return target == fs.ErrExist }
//
// then Is(MyError{}, fs.ErrExist) returns true. See syscall.Errno.Is for
// an example in the standard library.
func Is(err, target error) bool { return errors.Is(err, target) }

// As finds the first error in err's chain that matches target, and if so, sets
// target to that error value and returns true. Otherwise, it returns false.
//
// The chain consists of err itself followed by the sequence of errors obtained
// by repeatedly calling Unwrap.
//
// An error matches target if the error's concrete value is assignable to the
// value pointed to by target, or if the error has a method As(interface{}) bool
// such that As(target) returns true. In the latter case, the As method is
// responsible for setting target.
//
// An error type might provide an As method so it can be treated as if it were a
// different error type.
//
// As panics if target is not a non-nil pointer to either a type that implements
// error, or to any interface type.
func As(err error, target interface{}) bool { return errors.As(err, target) }

// Unwrap returns the result of calling the Unwrap method on err, if err's type
// contains an Unwrap method returning error. Otherwise, Unwrap returns nil.
func Unwrap(err error) error { return errors.Unwrap(err) }

// Errorf formats according to a format specifier and returns the string as a
// value that satisfies error.
//
// If the format specifier includes a %w verb with an error operand, the
// returned error will implement an Unwrap method returning the operand. It is
// invalid to include more than one %w verb or to supply it with an operand that
// does not implement the error interface. The %w verb is otherwise a synonym
// for %v.
func Errorf(format string, a ...interface{}) error { return fmt.Errorf(format, a...) }

// WithMessage annotates err with a new message. If err is nil, WithMessage
// returns nil.
func WithMessage(err error, message string) error {
if err == nil {
return nil
}
return fmt.Errorf("%s: %w", message, err)
}

// WithMessagef annotates err with the format specifier. If err is nil,
// WithMessagef returns nil.
func WithMessagef(err error, format string, args ...interface{}) error {
if err == nil {
return nil
}
return fmt.Errorf("%s: %w", fmt.Sprintf(format, args...), err)
}

// Wrap is an alias for WithMessage.
func Wrap(err error, message string) error {
return WithMessage(err, message)
}

// Wrapf is an alias for WithMessagef
func Wrapf(err error, format string, args ...interface{}) error {
return WithMessagef(err, format, args...)
}

// Cause calls Unwrap on each error it finds. It returns the first error it
// finds that does not have an Unwrap method - i.e. the first error that was not
// the result of a Wrap call, a Wrapf call, or an Errorf call with %w wrapping.
func Cause(err error) error {
type wrapped interface {
Unwrap() error
}

for err != nil {
// We're ignoring errorlint telling us to use errors.As because
// we actually do want to check the outermost error.
//nolint:errorlint
w, ok := err.(wrapped)
if !ok {
return err
}
err = w.Unwrap()
}

return err
}
126 changes: 126 additions & 0 deletions pkg/errors/errors_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
/*
Copyright 2021 The Crossplane Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package errors

import (
"testing"

"github.com/google/go-cmp/cmp"

"github.com/crossplane/crossplane-runtime/pkg/test"
)

func TestWrap(t *testing.T) {
type args struct {
err error
message string
}
cases := map[string]struct {
args args
want error
}{
"NilError": {
args: args{
err: nil,
message: "very useful context",
},
want: nil,
},
"NonNilError": {
args: args{
err: New("boom"),
message: "very useful context",
},
want: Errorf("very useful context: %w", New("boom")),
},
}

for name, tc := range cases {
t.Run(name, func(t *testing.T) {
got := Wrap(tc.args.err, tc.args.message)
if diff := cmp.Diff(tc.want, got, test.EquateErrors()); diff != "" {
t.Errorf("Wrap(...): -want, +got:\n%s", diff)
}
})
}
}

func TestWrapf(t *testing.T) {
type args struct {
err error
message string
args []interface{}
}
cases := map[string]struct {
args args
want error
}{
"NilError": {
args: args{
err: nil,
message: "very useful context",
},
want: nil,
},
"NonNilError": {
args: args{
err: New("boom"),
message: "very useful context about %s",
args: []interface{}{"ducks"},
},
want: Errorf("very useful context about %s: %w", "ducks", New("boom")),
},
}

for name, tc := range cases {
t.Run(name, func(t *testing.T) {
got := Wrapf(tc.args.err, tc.args.message, tc.args.args...)
if diff := cmp.Diff(tc.want, got, test.EquateErrors()); diff != "" {
t.Errorf("Wrapf(...): -want, +got:\n%s", diff)
}
})
}
}

func TestCause(t *testing.T) {
cases := map[string]struct {
err error
want error
}{
"NilError": {
err: nil,
want: nil,
},
"BareError": {
err: New("boom"),
want: New("boom"),
},
"WrappedError": {
err: Wrap(Wrap(New("boom"), "interstitial context"), "very important context"),
want: New("boom"),
},
}

for name, tc := range cases {
t.Run(name, func(t *testing.T) {
got := Cause(tc.err)
if diff := cmp.Diff(tc.want, got, test.EquateErrors()); diff != "" {
t.Errorf("Cause(...): -want, +got:\n%s", diff)
}
})
}
}
2 changes: 1 addition & 1 deletion pkg/fieldpath/fieldpath.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import (
"strings"
"unicode/utf8"

"github.com/pkg/errors"
"github.com/crossplane/crossplane-runtime/pkg/errors"
)

// A SegmentType within a field path; either a field within an object, or an
Expand Down
2 changes: 1 addition & 1 deletion pkg/fieldpath/fieldpath_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ import (
"testing"

"github.com/google/go-cmp/cmp"
"github.com/pkg/errors"

"github.com/crossplane/crossplane-runtime/pkg/errors"
"github.com/crossplane/crossplane-runtime/pkg/test"
)

Expand Down
2 changes: 1 addition & 1 deletion pkg/fieldpath/merge.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import (
"reflect"

"github.com/imdario/mergo"
"github.com/pkg/errors"

xpv1 "github.com/crossplane/crossplane-runtime/apis/common/v1"
"github.com/crossplane/crossplane-runtime/pkg/errors"
)

const (
Expand Down
3 changes: 2 additions & 1 deletion pkg/fieldpath/paved.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ limitations under the License.
package fieldpath

import (
"github.com/pkg/errors"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/util/json"

"github.com/crossplane/crossplane-runtime/pkg/errors"
)

type errNotFound struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/fieldpath/paved_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ import (
"testing"

"github.com/google/go-cmp/cmp"
"github.com/pkg/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/json"

"github.com/crossplane/crossplane-runtime/pkg/errors"
"github.com/crossplane/crossplane-runtime/pkg/test"
)

Expand Down
2 changes: 1 addition & 1 deletion pkg/meta/meta.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ import (
"strings"
"time"

"github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"

xpv1 "github.com/crossplane/crossplane-runtime/apis/common/v1"
"github.com/crossplane/crossplane-runtime/pkg/errors"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion pkg/meta/meta_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ import (
"time"

"github.com/google/go-cmp/cmp"
"github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"

xpv1 "github.com/crossplane/crossplane-runtime/apis/common/v1"
"github.com/crossplane/crossplane-runtime/pkg/errors"
"github.com/crossplane/crossplane-runtime/pkg/test"
)

Expand Down
Loading

0 comments on commit 6a7a44a

Please sign in to comment.