switch from "up xpkg" to "crossplane xpkg" #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Avarei
commented
Sep 22, 2024
Comment on lines
-22
to
-27
| # xref https://github.com/upbound/provider-aws/pull/647, https://github.com/upbound/up/pull/309 | ||
| # in up v0.16.0, support for ProviderConfig documentation via object annotations was added. | ||
| # by convention, we will assume the extensions file resides in the package directory. | ||
| ifeq ($(origin XPKG_AUTH_EXT),undefined) | ||
| XPKG_AUTH_EXT := $(XPKG_DIR)/auth.yaml | ||
| endif |
There was a problem hiding this comment.
I do not quite understand what this is for. but does not seem to be supported by the crossplane-cli
There was a problem hiding this comment.
I don't recall the history here. 🤔
@turkehnf @sergenyalcin do you know if removing this will be a problem for upjet providers?
negz
reviewed
Sep 25, 2024
Comment on lines
-22
to
-27
| # xref https://github.com/upbound/provider-aws/pull/647, https://github.com/upbound/up/pull/309 | ||
| # in up v0.16.0, support for ProviderConfig documentation via object annotations was added. | ||
| # by convention, we will assume the extensions file resides in the package directory. | ||
| ifeq ($(origin XPKG_AUTH_EXT),undefined) | ||
| XPKG_AUTH_EXT := $(XPKG_DIR)/auth.yaml | ||
| endif |
There was a problem hiding this comment.
I don't recall the history here. 🤔
@turkehnf @sergenyalcin do you know if removing this will be a problem for upjet providers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some troubles with up xpkg push when trying to target ghcr.io so I fullfilled your TODO @negz.
I hope this helps :)