-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from "up xpkg" to "crossplane xpkg" #14
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
# xref https://github.com/upbound/provider-aws/pull/647, https://github.com/upbound/up/pull/309 | ||
# in up v0.16.0, support for ProviderConfig documentation via object annotations was added. | ||
# by convention, we will assume the extensions file resides in the package directory. | ||
ifeq ($(origin XPKG_AUTH_EXT),undefined) | ||
XPKG_AUTH_EXT := $(XPKG_DIR)/auth.yaml | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not quite understand what this is for. but does not seem to be supported by the crossplane-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall the history here. 🤔
@turkehnf @sergenyalcin do you know if removing this will be a problem for upjet providers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - thank you!
I'd like to get confirmation that this change will work for the bigger providers like provider-upjet-aws though before we merge.
# xref https://github.com/upbound/provider-aws/pull/647, https://github.com/upbound/up/pull/309 | ||
# in up v0.16.0, support for ProviderConfig documentation via object annotations was added. | ||
# by convention, we will assume the extensions file resides in the package directory. | ||
ifeq ($(origin XPKG_AUTH_EXT),undefined) | ||
XPKG_AUTH_EXT := $(XPKG_DIR)/auth.yaml | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall the history here. 🤔
@turkehnf @sergenyalcin do you know if removing this will be a problem for upjet providers?
I had some troubles with up xpkg push when trying to target ghcr.io so I fullfilled your TODO @negz.
I hope this helps :)