Update Upjet to v1.4.1-0.20241007154751-5cdf36996e4a #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickard-von-essen
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
3 tasks
This includes PR 441 which fixes scraping of Refs which contains lists. See upjet v1.4.1-0.20241007154751-5cdf36996e4a Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
|
Checking the newly added reference fields from the terraform registry
|
Signed-off-by: Fatih Türken <turkenf@gmail.com>
|
/test-examples="examples/cloudplatform/v1beta1/serviceaccount.yaml" |
|
/test-examples="examples/storage/v1beta2/bucket.yaml" |
|
/test-examples="examples/binaryauthorization/v1beta2/policy.yaml" |
|
/test-examples="examples/compute/v1beta2/instancetemplate.yaml" |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
|
/test-examples="examples/compute/v1beta2/instancetemplate.yaml" |
|
/test-examples="examples/binaryauthorization/v1beta2/policy.yaml" |
sergenyalcin
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks @rickard-von-essen for the upjet change (this also helped adding some new reference fields🎉) and consuming it here. Also thanks @turkenf for reviewing it. LGTM!
turkenf
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This updated upjet to
v1.4.1-0.20241007154751-5cdf36996e4awhich includes crossplane/upjet#441I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
This has been partly tested in #624.
And via uptest:
examples/cloudplatform/v1beta1/serviceaccount.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11466746111examples/storage/v1beta2/bucket.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11466747605examples/compute/v1beta2/instancetemplate.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11467922255examples/binaryauthorization/v1beta2/policy.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11467924811