-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add selectors cluster private endpoint #610
base: main
Are you sure you want to change the base?
Feature/add selectors cluster private endpoint #610
Conversation
76c15b4
to
984b284
Compare
Hi @bradkwadsworth-mw, thanks for the PR. For failed CI pipelines, please run |
I ran |
@turkenf Any ideas on how I should proceed? |
cf25db5
to
6a65aeb
Compare
@turkenf It looks like the tests are passing now. |
4ec146b
to
a997a66
Compare
@turkenf Just rebased against current main. |
/test-examples="examples/cloudplatform/v1beta1/serviceaccount.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort @bradkwadsworth-mw, I left two comments. And, do you have a specific reason for updating the build submodule, if not would you revert it to the same commit as main?
Signed-off-by: Brad Wadsworth <brad.wadsworth@eviden.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@eviden.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@eviden.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@eviden.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@eviden.com>
a997a66
to
070c165
Compare
@turkenf I think I fixed the issues. |
@bradkwadsworth-mw, as I mentioned here: do you have a specific reason for updating the build submodule, if not would you revert it to the same commit as main? |
And please squash your commits for a clean commit history. |
Description of your changes
Added resource selectors for
spec.forProvider.privateClusterConfig.privateEndpointSubnetwork
Fixes #609
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Applied to a local Kind cluster
manifest: