Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigee): add google_apigee_endpoint_attachment #573

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jul 15, 2024

Description of your changes

add google_apigee_endpoint_attachment

Fixes #564

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

via crossplane-playground project in gcp - enabled apigee api first, the deletion of endpointattachment can take up to 2 hours
image

kubectl get managed
NAME                                                            SYNCED   READY   EXTERNAL-NAME                         AGE
organization.apigee.gcp.upbound.io/apigee-endpoint-attachment   True     True    organizations/crossplane-playground   4h34m

NAME                                                                  SYNCED   READY   EXTERNAL-NAME                AGE
endpointattachment.apigee.gcp.upbound.io/apigee-endpoint-attachment   True     True    apigee-endpoint-attachment   3h2m

NAME                                                                    SYNCED   READY   EXTERNAL-NAME                         AGE
subnetwork.compute.gcp.upbound.io/apigee-endpoint-attachment            True     True    apigee-endpoint-attachment            3h31m
subnetwork.compute.gcp.upbound.io/apigee-endpoint-attachment-internal   True     True    apigee-endpoint-attachment-internal   3h22m

NAME                                                                  SYNCED   READY   EXTERNAL-NAME                AGE
regionhealthcheck.compute.gcp.upbound.io/apigee-endpoint-attachment   True     True    apigee-endpoint-attachment   3h26m

NAME                                                               SYNCED   READY   EXTERNAL-NAME                AGE
forwardingrule.compute.gcp.upbound.io/apigee-endpoint-attachment   True     True    apigee-endpoint-attachment   3h21m

NAME                                                                     SYNCED   READY   EXTERNAL-NAME                AGE
regionbackendservice.compute.gcp.upbound.io/apigee-endpoint-attachment   True     True    apigee-endpoint-attachment   3h25m

NAME                                                                  SYNCED   READY   EXTERNAL-NAME                AGE
serviceattachment.compute.gcp.upbound.io/apigee-endpoint-attachment   True     True    apigee-endpoint-attachment   3h8m

NAME                                                              SYNCED   READY   EXTERNAL-NAME                AGE
globaladdress.compute.gcp.upbound.io/apigee-endpoint-attachment   True     True    apigee-endpoint-attachment   3h31m

NAME                                                        SYNCED   READY   EXTERNAL-NAME                AGE
network.compute.gcp.upbound.io/apigee-endpoint-attachment   True     True    apigee-endpoint-attachment   3h31m

NAME                                                                     SYNCED   READY   EXTERNAL-NAME                                                                                                        AGE
connection.servicenetworking.gcp.upbound.io/apigee-endpoint-attachment   True     True    projects%2Fcrossplane-playground%2Fglobal%2Fnetworks%2Fapigee-endpoint-attachment:servicenetworking.googleapis.com   3h31m

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort @haarchri 🙌

I didn't see any manual intervention. If you did not trigger uptest just because of timeout, we can add uptest.upbound.io/timeout: "7200" and try. Otherwise, we should add manual intervention.

@haarchri haarchri force-pushed the feature/apigee-endpoint-attachment branch 2 times, most recently from ecfde51 to 4c2a4f4 Compare July 22, 2024 11:46
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging previous PR conflict occurred. It might be better to add resources that the same group with one PR.

After resolving conflicts, we can merge, thank you.

@haarchri haarchri force-pushed the feature/apigee-endpoint-attachment branch from 4c2a4f4 to 67111d9 Compare July 23, 2024 08:55
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri force-pushed the feature/apigee-endpoint-attachment branch from 67111d9 to d3e9918 Compare July 23, 2024 08:58
@haarchri haarchri requested a review from turkenf July 23, 2024 09:06
@turkenf turkenf merged commit 3e8fdf5 into crossplane-contrib:main Jul 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for google_apigee_endpoint_attachment resource
2 participants