Feat/add tags group #558
Feat/add tags group #558
Conversation
declement
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
Signed-off-by: declement <clementde@padok.fr>
Signed-off-by: declement <clementde@padok.fr>
declement
force-pushed
the
feat/add-tags-group
branch
from
8ab8e0b
to
9d300dc
Compare
|
/test-examples="examples/tags/v1beta1/tagbinding.yaml" |
There was a problem hiding this comment.
Hey, @declement, many thanks for the contribution. I left two small comments about manual intervention annotations.
Co-authored-by: Fatih Türken <103541666+turkenf@users.noreply.github.com> Signed-off-by: declement <clementde@padok.fr>
declement
force-pushed
the
feat/add-tags-group
branch
from
d73edd3
to
a8cf767
Compare
|
Thank you for the quick reply, your suggestions have been applied. |
|
/test-examples="examples/tags/v1beta1/tagbinding.yaml,examples/tags/v1beta1/tagvalue.yaml,examples/tags/v1beta1/tagkey.yaml" |
Since you are a first-time contributor, you are not currently allowed to trigger uptest. Once this PR is merged, you can trigger it on new PRs you will open. Additionally, it will skip uptests since there is manual intervention in all of the examples. |
Description of your changes
This PR adds the ability to manage GCP resource tags through Crossplane.
This PR implements resources in #216. It is a follow up to #397 that were closed due to inactivity.
Implemented resources
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
This code has been tested manually (for creation, import and deletion) in a dedicated GCP project because Tag resources require existing parent resources.
google_tags_tag_key
google_tags_tag_value
google_tags_tag_binding