Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asg): fix observed failed availability_zones / vpc_zone_identifier #110

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Nov 1, 2022

Signed-off-by: Christopher Paul Haar christopherpaul.haar@dkb.de

Description of your changes

we tested today upbound/provider-aws and found one Issue regarding fields in asg availability_zones - looks like this issue has open PRs in crossplane-contrib/provider-jet-aws as well

observe failed: cannot run refresh: refresh failed: Conflicting configuration arguments: "availability_zones": conflicts with vpc_zone_identifier: File name: main.tf.json
Conflicting configuration arguments: "vpc_zone_identifier": conflicts with availability_zones: File name: main.tf.json

crossplane-contrib/provider-jet-aws#238

Fixes #106

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Christopher Paul Haar <christopherpaul.haar@dkb.de>
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would it be straight-forward to replace the example with your manifest? It sounds like the YAML you folks are using is more complicated and covers more ground.

@ulucinar ulucinar merged commit 18593b3 into crossplane-contrib:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoScaling Group Creation is not working.
4 participants