Support to Add, Remove and List ACLs (Fixes #6) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
…trolList to pass golint rules Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
ACL fixes and readme updates
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
Signed-off-by: jograca <jon.graca@gmail.com>
…date error message Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
elohmrow
reviewed
Feb 22, 2022
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
turkenh
reviewed
Feb 24, 2022
Co-authored-by: Hasan Turken <turkenh@gmail.com>
Co-authored-by: Hasan Turken <turkenh@gmail.com>
Co-authored-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Co-authored-by: Hasan Turken <turkenh@gmail.com>
… and refactoring code to use ResourceName instead of explicit Name Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
twmb
reviewed
Feb 25, 2022
Signed-off-by: Mallory Quaintance <mallory.quaintance@libertymutual.com>
stevendborrelli
requested changes
Mar 2, 2022
There was a problem hiding this comment.
Overall it looks good!
Need to run make reviewable test, as there are some linting errors.
apis/acl/v1alpha1/acl_types.go:31: File is not `gofmt`-ed with `-s` (gofmt)
ResourceName string `json:"resourceName"`
internal/clients/kafka/acl/acl.go:19: File is not `gofmt`-ed with `-s` (gofmt)
ResourceName string
internal/controller/acl/acl.go:194: File is not `gofmt`-ed with `-s` (gofmt)
return managed.ExternalCreation{}, acl.Create(ctx, c.kafkaClient, generated)
internal/clients/kafka/topic/topic_test.go:6: File is not `goimports`-ed with -local github.com/crossplane-contrib/provider-kafka (goimports)
"github.com/crossplane-contrib/provider-kafka/apis/topic/v1alpha1"
internal/controller/acl/acl.go:146:11: ineffectual assignment to `err` (ineffassign)
extname, err := acl.ConvertFromJSON(meta.GetExternalName(cr))
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
stevendborrelli
approved these changes
Mar 9, 2022
stevendborrelli
approved these changes
Mar 9, 2022
| } | ||
|
|
||
| // List lists all the ACLs in Kafka | ||
| func List(ctx context.Context, cl *kadm.Client, accessControlList *AccessControlList) (*AccessControlList, error) { |
There was a problem hiding this comment.
Linting is coming up with one more issue cyclomatic complexity 11 of func List is high (> 10)
Cyclomatic complexity is used as a metric for the complexity of tests required and we see it often in controllers. (see https://github.com/fzipp/gocyclo).
Maybe in future releases some of the logic can be factored out into functions.
To fix, add the // nolint:gocyclo comment to the function like so:
func List(ctx context.Context, cl *kadm.Client, accessControlList *AccessControlList) (*AccessControlList, error) { // nolint:gocyclo
|
🎉 |
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This Pull Request adds feature complete ACL support to Add, Remove and List ACLs.
Fixes #6
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Automated tests are forthcoming
kcl admin acl describe --type any --pattern match --op any --perm any