Bundled package #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
commented
Sep 19, 2022
displague
commented
Sep 19, 2022
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
force-pushed
the
bundled-package
branch
from
964afa4 to
d1732cb
Compare
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
force-pushed
the
bundled-package
branch
from
d1732cb to
455d87a
Compare
|
I believe we'll need the Docker crossplane-contrib provider-jet-equinix image repository created in advance of a merge so the 'latest' image can be pushed. I've created https://cloud.upbound.io/equinix/repositories/provider-jet-equinix but we'll need a valid secret added to the GH settings. |
hasheddan
reviewed
Sep 21, 2022
Makefile
Outdated
| # ==================================================================================== | ||
| # Setup XPKG | ||
|
|
||
| XPKG_REG_ORGS ?= xpkg.upbound.io/crossplane index.docker.io/crossplane |
There was a problem hiding this comment.
If you want to publish in equinix org on marketplace we would need to update to xpkg.upbound.io/equinix -- is that preferable?
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
force-pushed
the
bundled-package
branch
from
31e7cc8 to
ff44b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In order to fix image publishing, we'll need provider-jet-equinix image repos created (per #5). This PR sets up the new single image repo convention.
Publishes a single image for package metadata and the controller.
Uploads the image to the Upbound registry.
Borrows from crossplane-contrib/provider-gcp#456
Part of #5
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested