Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Configure azurerm_container_registry_token #138

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lippertmarkus
Copy link

@lippertmarkus lippertmarkus commented Jan 29, 2022

Description of your changes

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@lippertmarkus lippertmarkus marked this pull request as draft January 29, 2022 20:47
@lippertmarkus lippertmarkus changed the title add config for scope maps Configure azurerm_container_registry_token Jan 29, 2022
@ulucinar
Copy link
Collaborator

ulucinar commented Feb 2, 2022

Hi @lippertmarkus,
We generally require PRs introducing new MRs (Managed Resource) to also include a tested example manifest under the appropriate API group folder examples/<API group>. Could you please also provide an example manifest? You can also test this PR with that example manifest and specify this under the "How has this code been tested" section.

We also require GPG-signed commits and a sign-off in the commit message (e.g., commit message generated with git commit -s).

Thank you very much!

@lippertmarkus
Copy link
Author

lippertmarkus commented Feb 3, 2022

Thanks! I'll need some days to get back to this and figure out how I can test this. Do you have a guide on how to test? Building a new provider/controller image and use them? Found the steps for configuring a resource but nothing on testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants