This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add ECS, ECR, ALB, EC2 and Autoscaling resources #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
changed the title
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
muvaf
reviewed
Oct 11, 2021
config/lbv2/config.go
Outdated
| Type: "Lb", | ||
| }, | ||
| "default_action[*].target_group_arn": { | ||
| Type: "LbTargetGroup", |
There was a problem hiding this comment.
Do you know why Lb group prefix isn't dropped?
There was a problem hiding this comment.
Fixed it but unfortunately could not use "TargetGroup" because:
// Note(turkenh): Without setting Kind here, we get kind as "TargetGroup"
// which sounds better however, generator fails with the following since
// it conflicts with lblisters "TargetGroupParameters":
//
// panic: cannot generate crd: cannot build types for TargetGroup:
// cannot build the types: cannot generate parameters type name of
// TargetGroup: could not generate a unique name for TargetGroupParameters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
changed the title
muvaf
approved these changes
Oct 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hasan Turken turkenh@gmail.com