This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Update terrajet commit and check the time linting takes #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
force-pushed
the
test-lint-improvement
branch
from
7659577 to
688b086
Compare
sergenyalcin
changed the title
…nerated.terraformed.go Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
test-lint-improvement
branch
from
688b086 to
3b38c2c
Compare
|
Local run results for linting: With generated single terraformed file: Without generated single terraformed file: It seems that there is an improvement here. However, at this point, it would be logical to consider the working cache mechanisms. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related #108
The following commit of terrajet is used: crossplane/terrajet@fd4224b
Then we can compare the two jobs to check whether this change helps us.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested