Update Crossplane Runtime to v0.13 #57
Conversation
- update xpr core.v1alpha1 to common.v1 - renames corev1 to xpv1 - update upbound build to latest - update packngo to latest Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
|
@hasheddan I'm curious if there are any other important changes between v0.10 and v0.13 of XP-runtime that I may be missing. The most notable (only?) change that I encountered here was in the ProviderCrential handling. I imagine I will need to update the documentation and example provider details. |
| deviceClient := CredentialedClient{ | ||
| Client: client.Client.Devices, | ||
| PortsClient: client.Client.DevicePorts, | ||
| PortsClient: client.Client.DevicePorts, //nolint:staticcheck | ||
| Credentials: client.Credentials, | ||
| } |
There was a problem hiding this comment.
@displague along with those new credentials sources, we have some helpers to extract them so you can automatically get support for things like putting credentials in the filesystem or env vars. Here is an example :) https://github.com/crossplane/provider-aws/blob/959cc5b741fd7c2dafa7e20cac75ab55ae2c79bb/pkg/clients/aws.go#L105
There was a problem hiding this comment.
I think I've got those changes applied. I noticed the TestConnect tests were no longer present in other providers. I updated them in this provider after copying some private error message consts from crossplane-runtime.
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
There was a problem hiding this comment.
Looks good to me! As we discussed offline, the changes reflected in crossplane/crossplane#2334 can also be made here since you are pulling in latest build. I'll go ahead and approve though as changes should not alter functionality :)
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Description of your changes
Updates Crossplane Runtime to v0.13
Part of #56
Checklist
I have:
make reviewableto ensure this PR is ready for review.