Skip to content

Commit

Permalink
Merge pull request #64 from displague/port-does-not-exist
Browse files Browse the repository at this point in the history
treat 404 on device port lookups as a deleted port attachment
  • Loading branch information
displague authored Jun 14, 2021
2 parents fd7045e + a385e95 commit 072769d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/controller/ports/assignment/managed.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func (e *external) Observe(ctx context.Context, mg resource.Managed) (managed.Ex
// Observe port
port, err := e.client.GetPortByName(a.Spec.ForProvider.DeviceID, a.Spec.ForProvider.Name)
if packetclient.IsNotFound(err) {
return managed.ExternalObservation{}, errors.New("port does not exist")
return managed.ExternalObservation{ResourceExists: false}, nil
}
if err != nil {
return managed.ExternalObservation{}, errors.Wrap(err, errGetPort)
Expand Down

0 comments on commit 072769d

Please sign in to comment.