Allow usage of IAM/S3 resources in non-standard partitions #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support endpoint overrides in iso partitions report correct partition in reported s3 status arn Signed-off-by: Ben McDonie <bmcdonie@awetomaton.com>
zonybob
changed the title
haarchri
approved these changes
May 28, 2022
This was referenced May 28, 2022
2 tasks
2 tasks
emelieakerstrom-sb1
pushed a commit
to sparebank1utvikling/provider-aws
that referenced
this pull request
Sep 28, 2022
support endpoint overrides in iso partitions report correct partition in reported s3 status arn Signed-off-by: Ben McDonie <bmcdonie@awetomaton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This pull request does a few things to enable use in AWS ISO partitions...
ProviderConfigby upgrading aws-sdk-go-v2 (taken from upgrade to aws-sdk-go-v2 - 2021-12-03 #1020 )SigningRegionon ISO partitionsstatus.arnfieldFixes #1328
Fixes #1017
Fixes #1266
Might fix? #596
Relates to / extended from PR #1020
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Before this change, I was unable to provision IAM resources or get proper S3 ARN status fields in AWS ISO partitions. After this change, I can provision, observe and delete IAM resources and see proper ARN reported on S3 bucket status in ISO partitions.