-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to log.warning instead of log.warn #1648
base: master
Are you sure you want to change the base?
Conversation
log.warn is removed in Python 3.13 Close crossbario#1098
966a86c
to
e37d449
Compare
From what I understand of the error, I may be completely wrong on how to solve this: I seem to have modified calls to twited Testing this properly is made harder by the fact that pyunormalize cannot be installed on Python 3.13 yet Any insights no this? |
thanks for taking care of such things .. pls lemme comment ..
if so, then
once that is done, this PR can continue .. right now, 3.13 is not yet released currently, the CI uses CPython 3.11 and PyPy 3.9
and PyPy is now at 3.10 https://pypy.org/download.html for the CI upgrade PR, we should first define the exact version goals for CPython and for PyPy .. |
Sounds good to me. I started looking into it because fedora is starting to switch to 3.13 in its dev version and it seemed easy to do (sadly I was proven wrong). But, yes, we can wait for Python 3.13 to be officially release and migrate the CI first. |
I'm confident this ordering will support Autobahn's goal of improving robustness & production stability. if there is an issue in Autobahn triggered by a dependency upgrade, the issue should first be proven to actually exist and be valid this requires the CI to first not touch any code, but only upgrade the dependency, and then demoonstrate at least one failing test (which previously worked). if no such test currently exists which can demonstrate the issue, a new test case should be added once the issue is confirmed (by a test that transitioned from GREEN to RED), the issue can be fixed in another PR this allows to exactly follow the sequence of events with proof at each step, and the option for relatively easy rollback should something go wrong. as there will more often than not in reality;) like ripples in a subsequent, dependent project like Crossbar.io (which obviously uses Autobahn a lot) .. |
log.warn is removed in Python 3.13
Close #1098