Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add way to run script with pre-build #910

Merged
merged 1 commit into from
Jul 8, 2022
Merged

add way to run script with pre-build #910

merged 1 commit into from
Jul 8, 2022

Conversation

Emilgardis
Copy link
Member

Solves #861

@Emilgardis Emilgardis force-pushed the pre-build-copy branch 2 times, most recently from 83fe58c to 1222225 Compare July 4, 2022 20:15
Emilgardis
Emilgardis commented Jul 4, 2022
View reviewed changes
src/docker/shared.rs Outdated Show resolved Hide resolved
src/docker/shared.rs Outdated Show resolved Hide resolved
@Emilgardis Emilgardis marked this pull request as ready for review July 4, 2022 21:32
@Emilgardis Emilgardis requested a review from a team as a code owner July 4, 2022 21:32
@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Jul 6, 2022 •
edited
Loading

I'm guessing that how it serializes/deserializes to JSON is irrelevant, since it will never be JSON userfacing, so serializing to/from an object is fine. Just fix the conflicts and merge when ready.

@Emilgardis Emilgardis force-pushed the pre-build-copy branch 2 times, most recently from 228edeb to 96e4536 Compare July 6, 2022 17:53
@Alexhuszagh
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 8, 2022

Build succeeded:

@bors bors bot merged commit ddccccd into cross-rs:main Jul 8, 2022
@Emilgardis Emilgardis deleted the pre-build-copy branch July 8, 2022 09:24
@Alexhuszagh Alexhuszagh mentioned this pull request Jul 9, 2022
Closed
2 tasks
@Alexhuszagh Alexhuszagh added enhancement no-ci-targets PRs that do not affect any cross-compilation targets. labels Nov 6, 2022
@Emilgardis Emilgardis added this to the v0.2.3 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
enhancement no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Emilgardis @Alexhuszagh