Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow key-value pairs in config volumes. #750

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Allow volumes to use the ["VOL=/path/to/volume"]' syntax as well, so additional mount points can be defined by value in the env.volumes` section of the config file. Allows the following syntax:

[build.env]
volumes = ["VOL=/path/to/mount/"]

Not implementing it with the env.passthrough was a complete oversight on my part, related to #743 and #748.

Allow volumes to use the `["VOL=/path/to/volume"]' syntax as well, so
additional mount points can be defined by value in the config file.
@Alexhuszagh Alexhuszagh added enhancement A-config Area: cross-toml config labels Jun 3, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 3, 2022 13:43
@Alexhuszagh Alexhuszagh added the no changelog A valid PR without changelog (no-changelog) label Jun 3, 2022
@otavio
Copy link
Contributor

otavio commented Jun 3, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 3, 2022

Build succeeded:

@bors bors bot merged commit c72b1d7 into cross-rs:main Jun 3, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config Area: cross-toml config enhancement no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants