Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to color-eyre for error reporting #654

Merged
merged 3 commits into from
Mar 17, 2022
Merged

switch to color-eyre for error reporting #654

merged 3 commits into from
Mar 17, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

otavio
otavio requested changes Mar 16, 2022
View reviewed changes
src/config.rs Outdated Show resolved Hide resolved
@Emilgardis Emilgardis force-pushed the errors branch 2 times, most recently from e2755eb to e5613e7 Compare March 17, 2022 00:25
@Emilgardis Emilgardis mentioned this pull request Mar 17, 2022
Closed
@Emilgardis Emilgardis marked this pull request as ready for review March 17, 2022 15:41
@Emilgardis Emilgardis requested a review from a team as a code owner March 17, 2022 15:41
@Emilgardis
Copy link
Member Author

can't think of any more suggestion notes to add right now, more can be added later

otavio
otavio requested changes Mar 17, 2022
View reviewed changes
src/cargo.rs Outdated Show resolved Hide resolved
@Emilgardis Emilgardis force-pushed the errors branch 2 times, most recently from 3e9b054 to e3f916d Compare March 17, 2022 18:19
otavio
otavio requested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor thing ;-)

Cargo.toml Outdated Show resolved Hide resolved
reitermarkus
reitermarkus previously approved these changes Mar 17, 2022
View reviewed changes
otavio
otavio reviewed Mar 17, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@Emilgardis
Copy link
Member Author

bors r=reitermarkus

@bors
Copy link
Contributor

bors bot commented Mar 17, 2022

👎 Rejected by code reviews

@Emilgardis
Copy link
Member Author

bors r=reitermarkus

@bors
Copy link
Contributor

bors bot commented Mar 17, 2022

👎 Rejected by code reviews

@Emilgardis
Copy link
Member Author

hmm, bors shouldn't care about comments afaik

@Emilgardis
remove minor version specifiers in Cargo.toml
93af656 
this does not touch the libc req, but does move the libc req to a cfg gate
@reitermarkus
Copy link
Member

hmm, bors shouldn't care about comments afaik

I think it's because you pushed new commits which dismissed my approval, and bors requires one approval.

@reitermarkus
Copy link
Member

bors r+

@Emilgardis
Copy link
Member Author

hmm, bors shouldn't care about comments afaik

I think it's because you pushed new commits which dismissed my approval, and bors requires one approval.

ah, they were done exactly the same minute, but no dismissal message was shown

@Emilgardis
Copy link
Member Author

I also have this which I want to add when published: eyre-rs/color-eyre#106

@bors
Copy link
Contributor

bors bot commented Mar 17, 2022

Build succeeded:

@bors bors bot merged commit e93eb2f into cross-rs:main Mar 17, 2022
@Emilgardis Emilgardis deleted the errors branch March 17, 2022 20:49
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added the no-ci-targets PRs that do not affect any cross-compilation targets. label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio approved these changes

@reitermarkus reitermarkus reitermarkus approved these changes

Assignees
No one assigned
Labels
no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Emilgardis @reitermarkus @otavio @Alexhuszagh