freebsd: include libkvm in build image #613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Nov 23, 2021
613: freebsd: include libkvm in build image r=Emilgardis a=wg Cross builds targeting FreeBSD currently fail for projects depending on version 0.2.105+ of the libc crate due to a new dependency on libkvm, introduced here: rust-lang/libc@9ab890d#diff-75cac48df6376b0d5783bc764c591d1a896a92429653beda3f0b3e93aa8c339fR290 The compilation error looks like: ``` error: linking with `x86_64-unknown-freebsd12-gcc` failed: exit status: 1 ... = note: /usr/local/lib/gcc/x86_64-unknown-freebsd12/6.4.0/../../../../x86_64-unknown-freebsd12/bin/ld: cannot find -lkvm collect2: error: ld returned 1 exit status ``` This PR adds the static and shared libkvm binaries to the build image to resolve this issue. Co-authored-by: Will <will@glozer.net>
|
Build failed:
|
|
The build error was a certificate issue with curl I just tried to build this locally and it worked. Perhaps it was a fluke? |
I agree, lets try again bors retry note that this wont get published rn, see #609 |
bors bot
added a commit
that referenced
this pull request
Nov 27, 2021
613: freebsd: include libkvm in build image r=Emilgardis a=wg Cross builds targeting FreeBSD currently fail for projects depending on version 0.2.105+ of the libc crate due to a new dependency on libkvm, introduced here: rust-lang/libc@9ab890d#diff-75cac48df6376b0d5783bc764c591d1a896a92429653beda3f0b3e93aa8c339fR290 The compilation error looks like: ``` error: linking with `x86_64-unknown-freebsd12-gcc` failed: exit status: 1 ... = note: /usr/local/lib/gcc/x86_64-unknown-freebsd12/6.4.0/../../../../x86_64-unknown-freebsd12/bin/ld: cannot find -lkvm collect2: error: ld returned 1 exit status ``` This PR adds the static and shared libkvm binaries to the build image to resolve this issue. Co-authored-by: Will <will@glozer.net>
|
Build failed: |
|
Is it worth trying this again? The failures do still look unrelated to the changes here. I was also able to build locally. |
jszwedko
added a commit
to jszwedko/cross
that referenced
this pull request
Dec 29, 2021
Similar to cross-rs#613 include libdevstat seems to be required now too. Probably due to rust-lang/libc@ac6e16b Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
This was referenced Dec 29, 2021
|
@Emilgardis can we please get this merged? This is currently entirely broken without this change. |
Yes, this is to be included, however CI is completely broken right now, see #609 If you need this right now, you can use your own images. See https://github.com/rust-embedded/cross#custom-docker-images Sorry for the non-satisfactory workaround for this specific issue. You'd probably need to download the base.txz freebsd again. |
pitkley
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609
bors bot
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
32: fix: temporarily disable building and testing on FreeBSD r=pitkley a=pitkley CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609 Co-authored-by: Pit Kleyersburg <pitkley@googlemail.com>
pitkley
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609
bors bot
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
32: fix: temporarily disable building and testing on FreeBSD r=pitkley a=pitkley CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609 Co-authored-by: Pit Kleyersburg <pitkley@googlemail.com>
pitkley
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609
bors bot
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
32: fix: temporarily disable building and testing on FreeBSD r=pitkley a=pitkley CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609 Co-authored-by: Pit Kleyersburg <pitkley@googlemail.com>
svenstaro
added a commit
to svenstaro/cross
that referenced
this pull request
Feb 6, 2022
Contains fixes from cross-rs#613 and cross-rs#620
svenstaro
added a commit
to svenstaro/miniserve
that referenced
this pull request
Feb 6, 2022
We're currently waiting on cross-rs/cross#613 and cross-rs/cross#620 to be merged and released for cross. Until then, we're fixing this ourselves downstream with a custom FreeBSD image.
svenstaro
added a commit
to svenstaro/miniserve
that referenced
this pull request
Feb 6, 2022
We're currently waiting on cross-rs/cross#613 and cross-rs/cross#620 to be merged and released for cross. Until then, we're fixing this ourselves downstream with a custom FreeBSD image.
9 tasks
Emilgardis
pushed a commit
to Emilgardis/cross
that referenced
this pull request
Feb 6, 2022
Similar to cross-rs#613 include libdevstat seems to be required now too. Probably due to rust-lang/libc@ac6e16b Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Closed
|
included in #609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross builds targeting FreeBSD currently fail for projects depending on version 0.2.105+ of the libc crate due to a new dependency on libkvm, introduced here: rust-lang/libc@9ab890d#diff-75cac48df6376b0d5783bc764c591d1a896a92429653beda3f0b3e93aa8c339fR290
The compilation error looks like:
This PR adds the static and shared libkvm binaries to the build image to resolve this issue.