Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use runner setting specified in Cross.toml #500

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Dec 11, 2020

fixes #499

@japaric japaric requested review from Dylan-DPC-zz and a team as code owners December 11, 2020 17:37
reitermarkus
reitermarkus previously approved these changes Dec 12, 2020
@reitermarkus
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 12, 2020
497: don't set RUSTFLAGS in aarch64-musl image r=reitermarkus a=japaric

instead use a linker wrapper to work around issue rust-lang/rust#46651
not setting RUSTFLAGS inside the container lets end users pass rustc flags via `.cargo/config`
this is an alternative to #464 that doesn't require bumping the MSRV of the `aarch64-unknown-linux-musl` target (that is the aarch64-musl image will continue to work with Rust 1.42 where bug rust-lang/rust#46651 is still presen )

500: use runner setting specified in Cross.toml r=reitermarkus a=japaric

fixes #499 

Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
@bors
Copy link
Contributor

bors bot commented Dec 12, 2020

Build failed (retrying...):

bors bot added a commit that referenced this pull request Dec 12, 2020
500: use runner setting specified in Cross.toml r=reitermarkus a=japaric

fixes #499 

Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
@bors
Copy link
Contributor

bors bot commented Dec 12, 2020

Build failed:

@reitermarkus
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 13, 2020
500: use runner setting specified in Cross.toml r=reitermarkus a=japaric

fixes #499 

Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
@bors
Copy link
Contributor

bors bot commented Dec 13, 2020

Build failed:

@japaric
Copy link
Contributor Author

japaric commented Dec 14, 2020

it seems that the debian sysroot that's used by the qemu-system mode is missing a shared library. This is the output of cross test with CROSS_DEBUG=1:

dropbear: error while loading shared libraries: libtomcrypt.so.1: cannot open shared object file: No such file or directory
[    2.593663] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00007f00
[    2.593663]
[    2.594109] CPU: 2 PID: 1 Comm: dropbear Not tainted 4.19.0-11-arm64 #1 Debian 4.19.146-1
[    2.594255] Hardware name: linux,dummy-virt (DT)
[    2.595546] Call trace:

@japaric
Copy link
Contributor Author

japaric commented Dec 14, 2020

it seems that the debian sysroot that's used by the qemu-system mode is missing a shared library.

last two commits should fix this
(ah, I forgot to run shellcheck locally)

@reitermarkus
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 14, 2020

Build succeeded:

@bors bors bot merged commit 9bf60e7 into master Dec 14, 2020
@bors bors bot deleted the read-runner-setting branch December 14, 2020 16:49
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross.toml: runner setting is ignored
3 participants