Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with rustup toolchain overrides causing redundant channel update syncing #456

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Fix bug with rustup toolchain overrides causing redundant channel update syncing #456

merged 1 commit into from
Oct 23, 2020

Conversation

kay
Copy link
Contributor

@kay kay commented Sep 3, 2020

The issue is that cross is trying to call rustup toolchain add XX on every run when toolchain overrides are in use.

Replication & more detail on the issue is given in this repo: https://github.com/kay/cross-toolchain-override-bug

This uses a rust-toolchain file to override you can also replicate using rustup override set 1.45.1 as described here

Going by the latest rustup source, this is the relevant code that enumerates the various annotations outputted for toolchains: and it looks like (default) and (override) are the only ones that may be output for running rustup toolchain list as cross -V would.

@kay kay requested review from Dylan-DPC-zz and a team as code owners September 3, 2020 16:44
@reitermarkus
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 23, 2020

Build succeeded:

@bors bors bot merged commit 6ff4818 into cross-rs:master Oct 23, 2020
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants