Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fully enabling emscripten targets again. #317

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Try fully enabling emscripten targets again. #317

merged 1 commit into from
Sep 9, 2019

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 9, 2019 •
edited
Loading

Closes #232.

@rust-highfive
Copy link

r? @jamesmunns

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2019
@Dylan-DPC-zz
Copy link

bors: try

bors bot added a commit that referenced this pull request Sep 9, 2019
@bors
Try #317:
77b8120
@bors
Copy link
Contributor

bors bot commented Sep 9, 2019

try

Build failed

  • rust-embedded.cross

@reitermarkus
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Sep 9, 2019
@bors
Try #317:
7933844
@bors
Copy link
Contributor

bors bot commented Sep 9, 2019

try

Build succeeded

  • rust-embedded.cross

@reitermarkus
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Sep 9, 2019
@bors @reitermarkus
Merge #317
a43d540 
317: Try fully enabling `emscripten` targets again. r=reitermarkus a=reitermarkus



Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Sep 9, 2019

Build succeeded

  • rust-embedded.cross

@bors bors bot merged commit 2518c2b into cross-rs:master Sep 9, 2019
@reitermarkus reitermarkus deleted the emscripten branch September 9, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

@jamesmunns jamesmunns Awaiting requested review from jamesmunns

Assignees

@jamesmunns jamesmunns

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable asmjs
5 participants
@reitermarkus @rust-highfive @Dylan-DPC-zz @burrbull @jamesmunns