Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versioned_image_name. #304

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Conversation

reitermarkus
Copy link
Member

No description provided.

@burrbull
Copy link

burrbull commented Sep 6, 2019

can you show before/after example?

@reitermarkus
Copy link
Member Author

reitermarkus commented Sep 6, 2019

Before, the variable was missing from this script because I moved it into build-docker-image.sh, but it is needed both in build-docker-image.sh and in docker_push.sh.

If TAG=v0.1.15, versioned_image_name will be rustembedded/cross:${TARGET}-0.1.15.

@reitermarkus
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Sep 6, 2019
304: Fix `versioned_image_name`. r=reitermarkus a=reitermarkus



Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Sep 6, 2019

Build succeeded

  • rust-embedded.cross

@bors bors bot merged commit 9508672 into cross-rs:master Sep 6, 2019
@reitermarkus reitermarkus deleted the docker-push branch September 6, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants