WIP: Add clang & ssl #278
Closed
WIP: Add clang & ssl #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
reviewed
Jul 11, 2019
| @@ -15,7 +15,12 @@ RUN apt-get update && \ | |||
| autoconf \ | |||
| make \ | |||
| file \ | |||
| binutils | |||
| binutils \ | |||
| openssl \ | |||
There was a problem hiding this comment.
I don't think we should be adding openssl to images implicitly. See issue #229.
|
Closing this in favour of #229. I think only adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I"m trying to build my project using
trust(and thuscross) and after much investigation: it seems like I need clang and ( maybe, but I'm not sure) ssl-dev in cross containers. It's really common requirements to needclangin Rust projects, unfortunately. I guess ssl is probably already installed anyway, but I guess it doesn't hurt to make it explicit.Would a PR of this form be accepted? If so I can go over all other targets and make similiar modifications. If there's something to fix, please tell me now, before I copy it over 20 or so times. Thanks!