Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump arm-unknown-linux-gnueabihf to glibc 2.31 #1333

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Sep 14, 2023

resolves #1331

@Emilgardis Emilgardis requested a review from a team as a code owner September 14, 2023 19:37
@Emilgardis Emilgardis force-pushed the bump-glibc-arm-unknown-linux-gnueabihf branch from ea62176 to e09d3f8 Compare September 14, 2023 19:48
@Emilgardis
Copy link
Member Author

Emilgardis commented Sep 14, 2023

the script for checking versions (cargo xtask target-info) is not doing this correctly, will have to fix that in another pr. target-info does report the correct version, we just never reran it

@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf

we don't artifact the images, would be nice to have

bors bot added a commit that referenced this pull request Sep 14, 2023
@Emilgardis
Copy link
Member Author

ci has been running for more than the weekly no cache run does, hopefully it actually works, I wasn't able to build this myself due to using qemu

@bors
Copy link
Contributor

bors bot commented Sep 14, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

action timed out on dl, might have to bump build time

lets try once more

bors try --target arm-unknown-linux-gnueabihf

bors bot added a commit that referenced this pull request Sep 14, 2023
@bors
Copy link
Contributor

bors bot commented Sep 14, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf

bors bot added a commit that referenced this pull request Sep 14, 2023
@bors
Copy link
Contributor

bors bot commented Sep 15, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf

bors bot added a commit that referenced this pull request Sep 15, 2023
@bors
Copy link
Contributor

bors bot commented Sep 15, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf -v

bors bot added a commit that referenced this pull request Sep 15, 2023
@bors
Copy link
Contributor

bors bot commented Sep 15, 2023

try

Build failed:

@Emilgardis Emilgardis force-pushed the bump-glibc-arm-unknown-linux-gnueabihf branch from 9bbd850 to b3b0916 Compare September 15, 2023 08:07
@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf -v

bors bot added a commit that referenced this pull request Sep 15, 2023
@bors
Copy link
Contributor

bors bot commented Sep 15, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf -v

bors bot added a commit that referenced this pull request Sep 15, 2023
@bors
Copy link
Contributor

bors bot commented Sep 15, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf -v

forgot to push :)

bors bot added a commit that referenced this pull request Sep 15, 2023
@bors
Copy link
Contributor

bors bot commented Sep 15, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf -v

bors bot added a commit that referenced this pull request Sep 15, 2023
@bors
Copy link
Contributor

bors bot commented Sep 15, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target arm-unknown-linux-gnueabihf -v

bors bot added a commit that referenced this pull request Sep 16, 2023
@bors
Copy link
Contributor

bors bot commented Sep 16, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@Emilgardis
Copy link
Member Author

lets go!

@Emilgardis
Copy link
Member Author

Emilgardis commented Sep 16, 2023

side-note, should artifact the images or even publish them for a certain time period if needed, something like --publish

and then a check that goes through the images and removes stale temp images, this would be great for aarch64 platform images also

@Emilgardis Emilgardis force-pushed the bump-glibc-arm-unknown-linux-gnueabihf branch from 43118e6 to d47fb5f Compare September 16, 2023 19:32
@Emilgardis
Copy link
Member Author

Emilgardis commented Sep 16, 2023

I've published this as ghcr.io/emilgardis/arm-unknown-linux-gnueabihf:pr-1333

@aughey can you please try this image before I publish it officially? I tried it and seems to work with

FROM ghcr.io/emilgardis/arm-unknown-linux-gnueabihf:pr-1333

ARG CROSS_DEB_ARCH

RUN dpkg --add-architecture $CROSS_DEB_ARCH && apt-get update
RUN rm -f rm /etc/apt/preferences.d/all-packages
RUN apt-get install --assume-yes libudev-dev:$CROSS_DEB_ARCH libusb-1.0-0-dev:$CROSS_DEB_ARCH

@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect any cross-compilation targets. label Sep 16, 2023
@aughey
Copy link

aughey commented Sep 16, 2023

@Emilgardis My project was successfully built with this image! Good work.

README.md Outdated Show resolved Hide resolved
@Emilgardis Emilgardis force-pushed the bump-glibc-arm-unknown-linux-gnueabihf branch from d47fb5f to 48a6864 Compare September 16, 2023 22:09
use zlib 1.2.13 from github releases

use ct-ng from official releases and bump mpfr
@Emilgardis Emilgardis force-pushed the bump-glibc-arm-unknown-linux-gnueabihf branch from 48a6864 to 549c4bd Compare September 16, 2023 22:10
Copy link
Member Author

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 16, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3bfc6d5 into cross-rs:main Sep 16, 2023
22 checks passed
@Emilgardis
Copy link
Member Author

manual check started, image will be published once done
https://github.com/cross-rs/cross/actions/runs/6209933703

@Emilgardis Emilgardis deleted the bump-glibc-arm-unknown-linux-gnueabihf branch October 17, 2023 10:03
@Emilgardis Emilgardis added this to the v0.3.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arm-unknown-linux-gnueabihf - wrong glibc
2 participants