Build mips-unknown-linux-musl from Debian instead of Ubuntu to have access to their packages #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu does not support mips, so we cannot add libraries with pre-build configuration in Cross.toml. This changes the mipsel-unknown-linux-musl image to build from Debian stable. You can now use something like: ``` pre-build = ["dpkg --add-architecture mipsel && apt-get update && apt-get install -y zlib1g-dev:mipsel && ln -s /usr/include/zlib.h /usr/local/mipsel-linux-muslsf/include"] ```
sarfata
changed the title
Emilgardis
requested changes
Sep 14, 2023
There was a problem hiding this comment.
This is a good idea, but maybe we should keep the ubuntu based image just incase?
One issue I see is our override of sources here, should probably remove that for this target.
The ubuntu image can be kept as docker/Dockerfile.mipsel-unknown-linux-musl.ubuntu, it would then need to be added to targets.toml like we've done for centos
| @@ -49,7 +49,7 @@ if_centos() { | |||
| } | |||
|
|
|||
| if_ubuntu() { | |||
There was a problem hiding this comment.
this should probably be renamed to if_aptitude I think
joseluisq
reviewed
Oct 5, 2023
| @@ -1,4 +1,4 @@ | |||
| FROM ubuntu:20.04 | |||
| FROM debian:bookworm | |||
There was a problem hiding this comment.
Suggested change
| FROM debian:bookworm | |
| FROM debian:12.2-slim |
|
Sorry - Keep meaning to get back to this but have not found the time. Will close the PR for now and will re-open when I have applied the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu does not support mips, so we cannot add libraries with pre-build hooks like suggested in the documentation.
This changes the mipsel-unknown-linux-musl image to build from Debian stable.
You can now do:
I realize this is not a benign change but it ended up being pretty small. I am curious if this is something you would consider merging - or if you would suggest a better approach.