6pac/SlickGrid#9 : Prevent useless onSelectedRangesChanged events in …

…selectionmodels' setSelectedRanges
croc-code · May 29, 2015 · 50d9b7c · 50d9b7c
1 parent e004912
commit 50d9b7c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/plugins/slick.cellselectionmodel.js b/plugins/slick.cellselectionmodel.js
@@ -56,6 +56,9 @@
     }
 
     function setSelectedRanges(ranges) {
+      // simle check for: empty selection didn't change, prevent firing onSelectedRangesChanged
+      if ((!_ranges || _ranges.length === 0) && (!ranges || ranges.length === 0)) { return; }
+
       _ranges = removeInvalidRanges(ranges);
       _self.onSelectedRangesChanged.notify(_ranges);
     }

diff --git a/plugins/slick.rowselectionmodel.js b/plugins/slick.rowselectionmodel.js
@@ -81,6 +81,8 @@
     }
 
     function setSelectedRanges(ranges) {
+      // simle check for: empty selection didn't change, prevent firing onSelectedRangesChanged
+      if ((!_ranges || _ranges.length === 0) && (!ranges || ranges.length === 0)) { return; }
       _ranges = ranges;
       _self.onSelectedRangesChanged.notify(_ranges);
     }