Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fork exec: use clone3 CLONE_INTO_CGROUP #13

Open
criyle opened this issue Feb 20, 2025 · 0 comments
Open

fork exec: use clone3 CLONE_INTO_CGROUP #13

criyle opened this issue Feb 20, 2025 · 0 comments

Comments

@criyle
Copy link
Owner

criyle commented Feb 20, 2025

Support clone3 CLONE_INTO_CGROUP (kernel > 5.7) to replace existing group logic

Existing strategy includes:

  • syncFunc
  • cgroup.AddProc
  • unshareCgroupAfterSync

This syscall should reduce sync time.

Following the design of go1.20 implementation, the clone3 can be combined with vfork to reduce the consumption as well.
criyle added a commit that referenced this issue Feb 20, 2025
@criyle
cgroup&container: add ability to utilize cgroup fd with clone3
d32acd7 
#13
criyle added a commit that referenced this issue Feb 20, 2025
@criyle
forkexec: only sync when syncFunc exists
f8361a0 
#13
criyle added a commit that referenced this issue Feb 20, 2025
@criyle
forkexec: use vfork if no sync needed
659099a 
#13
criyle added a commit to criyle/go-judge that referenced this issue Feb 20, 2025
@criyle
linuxc: try support faster new clone3(CLONE_INTO_CGROUP) syscall
ffdf3e3 
criyle/go-sandbox#13
criyle added a commit that referenced this issue Feb 21, 2025
@criyle
container: fix cgroup fd
f0dd44f 
forkexec: disabled VFORK for now as it is not working properly
#13
criyle added a commit that referenced this issue Feb 21, 2025
@criyle
container: add unshare cgroup before exec
f9deb2d 
#13
criyle added a commit to criyle/go-judge that referenced this issue Feb 21, 2025
@criyle
linuxc: fix cgroup fd & add clean up to containers when exit
9ae8487 
criyle/go-sandbox#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@criyle