Use userScripts API for JavaScript actions #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tjhorner Nice fix, thank you. After building a release for Chrome I had to fix service_worker.js, a function name was missing (registerHandlers). |
|
@crittermike, when do you plan to publish a new release with this fix? I still see 4.1.3 from May in https://github.com/crittermike/shortkeys/releases |
Ahh, the name was minified wasn't it? Nice catch |
|
@tjhorner Yes, right. I'm going to create a PR to fix that and to add missing IDs upon update. Or may be you would like to do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #599.
The implementation is mostly complete (if a bit sloppy), but there is one missing piece: as part of this change, IDs for each shortcut are introduced. Shortcuts with missing IDs will be added on next save. This means users will need to go to the config page at least once before their JS shortcuts will work.
It's possible to perform this migration on extension update but I'm not sure how you wanted to go about it.