Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block the start of an environment deploy/app if the agent is disconnected #72

Merged
merged 13 commits into from
Feb 1, 2024

Conversation

afjsilva
Copy link
Contributor

@afjsilva afjsilva commented Jan 19, 2024

Was added code to call a new API CanStartDeploymentConnection() to check the agent connection status before start the deployment of an environment or app. When a deploymentTarget is remote, the API call occurs. If the depoyment can't start because the connection is not possible, an exception is throw.
This validation is for new environment deployments or apps.

Copy link
Contributor

@EgzysT EgzysT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Creating new environment" log should probably only be shown after the checking the infra agent connection, to avoid showing that log if the connection fails
image

@afjsilva
Copy link
Contributor Author

Creating new environment

Please check now :) Thx!

Co-authored-by: joseloc300 <JoseCunha@criticalmanufacturing.com>
@afjsilva afjsilva merged commit 204493d into main Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants