Add decorator for service & node name to allow using node metadata #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
suggested changes
Oct 2, 2020
samples/consul-ui/decorators.js.erb
Outdated
| @@ -36,6 +36,13 @@ function usefullLinksGenerator(instance, serviceName, node_meta_info) { | |||
| return top; | |||
| } | |||
|
|
|||
| /** | |||
| * instanceNameDecorator is called to resolve instance name. | |||
There was a problem hiding this comment.
it resolves and display the nodeName, instance is too vague
samples/consul-ui/decorators.js.erb
Outdated
| /** | ||
| * instanceNameDecorator is called to resolve instance name. | ||
| */ | ||
| function instanceNameDecorator(instance, nodemeta) { |
There was a problem hiding this comment.
I would rather call it: createNodeDisplayElement(nodeName, nodeMeta)
and return by default : document.createTextNode(nodeName) => So it can be used to display specific icons for instance
samples/consul-ui/js/utils.js
Outdated
| instanceLink.setAttribute('target', '_blank'); | ||
| } | ||
| instanceLink.appendChild(document.createTextNode(nodename)); | ||
| var name = instanceNameDecorator(node['Name'], node['Meta']) | ||
| instanceLink.appendChild(document.createTextNode(name)); |
There was a problem hiding this comment.
just do:
instanceLink.appendChild(createNodeDisplayElement(node['Name'], node['Meta']))
samples/consul-ui/js/utils.js
Outdated
| instanceLink.appendChild(document.createTextNode(instance.name + appendPort)); | ||
| var nodemeta = (node_info != null) ? node_info.meta : null; | ||
| var name = instanceNameDecorator(instance.name, nodemeta) | ||
| instanceLink.appendChild(document.createTextNode(name + appendPort)); |
There was a problem hiding this comment.
Just do:
instanceLink.appendChild(createNodeDisplayElement(instance.name, nodemeta))
PHBourquin
force-pushed
the
node_name_decorators
branch
from
ad0fed3
to
2bba6fa
Compare
In case meta needs to be used in place of node.name
PHBourquin
force-pushed
the
node_name_decorators
branch
from
2bba6fa
to
fd0024b
Compare
pierresouchay
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case meta needs to be used in place of node.name