Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .Net 4.6.2. Replace KB2919442 with KB3021910. #31

Merged
merged 1 commit into from
Nov 22, 2016

Conversation

Matasx
Copy link

@Matasx Matasx commented Oct 18, 2016

Signed-off-by: Martin Matatko matatko.martin@gmail.com

@Annih
Copy link
Contributor

Annih commented Oct 19, 2016

Thanks @Matasx I'll check this patch ASAP.

@Matasx
Copy link
Author

Matasx commented Nov 21, 2016

Hi, could you please review? Thanks.

Copy link
Contributor

@Annih Annih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK except my 2 comments.
Please also rebase properly on master (no merge commit please)

end,
options: '/norestart /quiet',
checksum: x64? ? 'c10787e669b484674584a990e069295e8b81b5366f98508010a3ae181b729482' : '3368c3a329f402fd982b15b399368627b96973f008a5456b5286bdfc10c1169b',
checksum: x64? ? 'FEB03C1C3D5719EC2E7873C0B9B85BB9E9DB44DF88C75F9DDD5222942E4BF928' : '971D1B18CB26E578926591EE944F7183BE7A6D7ABFC2E255B930803666EEBC20',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use downcase checksum

url: if x64?
'https://download.microsoft.com/download/D/6/0/D60ED3E0-93A5-4505-8F6A-8D0A5DA16C8A/Windows8.1-KB2919442-x64.msu'
'https://download.microsoft.com/download/6/1/5/615B8D87-A02C-485E-B9B5-D6F4AEB52D78/Windows8.1-KB3021910-x64.msu'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPT: use server url for the x64 version, this is the exacte same file so same checksum.
https://download.microsoft.com/download/7/7/4/77476115-26DA-42FC-B00F-031D2BB3740F/Windows8.1-KB3021910-x64.msu

@Annih
Copy link
Contributor

Annih commented Nov 21, 2016

Just for my information @Matasx was it hard/complexe to perform this update on the ms_dotnet cookbook?

@Matasx
Copy link
Author

Matasx commented Nov 21, 2016

Thanks for your notes. I will update my branch accordingly tomorrow. FYI it wasn't hard to perform those changes in cookbook itself. Only thing that was challenging for me was to find correct packages, prerequisites and registry checks on MS pages.

@Matasx
Copy link
Author

Matasx commented Nov 22, 2016

@Annih, hopefully everything should by addressed now.

Signed-off-by: Martin Matatko <matatko.martin@gmail.com>
Copy link
Contributor

@Annih Annih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it looks good to me :)

@Annih Annih merged commit 57107e1 into criteo-cookbooks:master Nov 22, 2016
@Annih
Copy link
Contributor

Annih commented Nov 22, 2016

@Matasx I'll prepare a new 4.0 version of this cookbook including your fix and the pending PR, is it OK for you; or do you need a quicker release?

@Matasx
Copy link
Author

Matasx commented Nov 22, 2016

@Annih thanks! What is your estimate? If it will be done somewhere in the middle of next week I think I am ok with that.

@Annih
Copy link
Contributor

Annih commented Nov 23, 2016

Release will be done today, but it'll be a 3.1 version instead of 4.0 as I previously said :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants