-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OpenAPI schema
field in I/O of process descriptions
#429
Conversation
…le EchoProcess package types
…le for outputs + working tests for WPS<->OAS conversions
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 80.79% 80.90% +0.11%
==========================================
Files 76 76
Lines 13421 14044 +623
Branches 2868 3058 +190
==========================================
+ Hits 10843 11362 +519
- Misses 1924 1981 +57
- Partials 654 701 +47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but I wonder if every functions in processes/concert.py
are somehow convered by the new tests in test_wps_package.py
? There's a lot of stuff there and it looks like it could be very easy to make a mistake.
Seems mostly covered (indirectly via existing tests), but a few misses here and there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Increase conformance with https://github.com/opengeospatial/ogcapi-processes by returning OpenAPI
schema
in process description and parsing them during deployment.When deploying a process, any complementary details defined in OAS
schema
are combined with other WPS/CWL definitions to resolve the final I/O definitions in each context.Implementation Notes
schema
of each I/O.File
for CWL. Complex I/O must still be given by HTTP/S3 reference for the moment. Again, some following PR at some point to address this.Experiments in combination with CubeWerx for interop testing of TEPs (quoting/billing/workflow) could help guide which features to prioritize next.
References
fixes #245
fixes https://crim-ca.atlassian.net/browse/CUBW-7