Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default data handling of optional file inputs for WPS-1 execution #344

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

@github-actions github-actions bot added ci/doc Issue related to documentation of the package feature/CWL Issue related to CWL support process/wps1 Issue related to WPS 1.x processes support labels Oct 7, 2021
fmigneault added a commit to Ouranosinc/pavics-sdi that referenced this pull request Oct 7, 2021
…tched inline until next weaver released and pushed in stack)
@fmigneault fmigneault requested a review from dbyrns October 7, 2021 02:45
@github-actions github-actions bot added the ci/tests Tests of the package and features label Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #344 (8ae15c0) into master (f35e0eb) will decrease coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   77.79%   77.77%   -0.03%     
==========================================
  Files          63       63              
  Lines        9981     9989       +8     
  Branches     1508     1511       +3     
==========================================
+ Hits         7765     7769       +4     
- Misses       1732     1734       +2     
- Partials      484      486       +2     
Impacted Files Coverage Δ
weaver/processes/convert.py 77.05% <ø> (-0.06%) ⬇️
weaver/typedefs.py 0.00% <ø> (ø)
weaver/processes/wps_package.py 71.24% <66.66%> (-0.26%) ⬇️
weaver/processes/wps1_process.py 74.78% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35e0eb...8ae15c0. Read the comment docs.

Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmigneault fmigneault merged commit 6de428c into master Oct 13, 2021
@fmigneault fmigneault deleted the wps1-cwl-defaults branch October 13, 2021 01:16
fmigneault added a commit to Ouranosinc/pavics-sdi that referenced this pull request Oct 13, 2021
…tched inline until next weaver released and pushed in stack)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/CWL Issue related to CWL support process/wps1 Issue related to WPS 1.x processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants