Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block unknown process type deployment (fixes #276) #288

Merged
merged 4 commits into from
Sep 1, 2021

Conversation

trapsidanadir
Copy link
Contributor

Explicitly block unsupported and builtin process type during deployment from the API.

@trapsidanadir trapsidanadir self-assigned this Aug 24, 2021
@github-actions github-actions bot added ci/tests Tests of the package and features feature/CWL Issue related to CWL support ci/doc Issue related to documentation of the package labels Aug 24, 2021
@trapsidanadir trapsidanadir changed the title Block unknown process type deployment(fixes #211) Block unknown process type deployment (fixes #211) Aug 24, 2021
@trapsidanadir trapsidanadir linked an issue Aug 24, 2021 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #288 (a586cb7) into master (0e0449a) will increase coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   73.36%   73.42%   +0.06%     
==========================================
  Files          61       61              
  Lines        9674     9680       +6     
  Branches     1431     1435       +4     
==========================================
+ Hits         7097     7108      +11     
+ Misses       2176     2171       -5     
  Partials      401      401              
Impacted Files Coverage Δ
weaver/processes/wps_package.py 66.71% <80.00%> (+0.97%) ⬆️
weaver/processes/utils.py 50.93% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0449a...a586cb7. Read the comment docs.

@trapsidanadir trapsidanadir changed the title Block unknown process type deployment (fixes #211) Block unknown process type deployment (fixes #276) Aug 24, 2021
@trapsidanadir trapsidanadir force-pushed the block-unknown-processes branch from eaf2885 to c077260 Compare August 24, 2021 19:31
@github-actions github-actions bot added the ci/operations Related to CI operations (actions, execution, install, builds, etc.) label Aug 24, 2021
tests/functional/test_wps_package.py Outdated Show resolved Hide resolved
tests/functional/test_wps_package.py Show resolved Hide resolved
weaver/processes/wps_package.py Show resolved Hide resolved
weaver/processes/wps_package.py Outdated Show resolved Hide resolved
@trapsidanadir
Copy link
Contributor Author

test_execute_job_with_inline_input_values and test_execute_job_with_array_input tests stopped passing after adding the new validations.

@fmigneault fmigneault force-pushed the block-unknown-processes branch from 3a92ce1 to a586cb7 Compare September 1, 2021 15:04
@fmigneault fmigneault merged commit a80f343 into master Sep 1, 2021
@fmigneault fmigneault deleted the block-unknown-processes branch September 1, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/CWL Issue related to CWL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Block unknown process type deployment
2 participants