Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGC-API v1.0-draft6 conformance #261

Merged
merged 42 commits into from
Sep 1, 2021
Merged

OGC-API v1.0-draft6 conformance #261

merged 42 commits into from
Sep 1, 2021

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Jun 10, 2021

Important

major version change should be considered since this modifies the content format returned by the "main" endpoint of process description

Changes

  • conformance of process description with OGC-API v1.0-draft6
    • process description content directly at the root
    • expected links ref items provided
    • more jobs ref links
  • better support datatype fields attr/property auto-resolution

@github-actions github-actions bot added ci/doc Issue related to documentation of the package feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Jun 10, 2021
@fmigneault fmigneault added the triage/conformance Issue related to fixing/ensuring compliance to specifications. label Jun 10, 2021
@fmigneault fmigneault added this to the OGC-API Conformances milestone Jun 11, 2021
@fmigneault fmigneault self-assigned this Jun 11, 2021
@fmigneault fmigneault force-pushed the process-desc-format branch 2 times, most recently from 0a8c333 to 245e973 Compare July 16, 2021 18:48
@github-actions github-actions bot added the ci/tests Tests of the package and features label Jul 16, 2021
@fmigneault fmigneault force-pushed the process-desc-format branch from 82aa958 to 3c80496 Compare August 12, 2021 22:46
@fmigneault fmigneault force-pushed the process-desc-format branch from 3c80496 to 60fc575 Compare August 12, 2021 23:25
@fmigneault fmigneault force-pushed the process-desc-format branch 2 times, most recently from fcd1860 to cfbe908 Compare August 20, 2021 17:30
@fmigneault fmigneault force-pushed the process-desc-format branch from a1f56f8 to 8aedaac Compare August 28, 2021 05:28
@github-actions github-actions bot added the feature/job Issues related to job execution, reporting and logging. label Aug 28, 2021
@fmigneault
Copy link
Collaborator Author

Tests test_get_provider_process_description_ogc_schema and test_get_provider_process_description_old_schema both fail due to missing processVersion retrieved from ProcessDescription (resolved by geopython/OWSLib#794).

@github-actions github-actions bot added ci/operations Related to CI operations (actions, execution, install, builds, etc.) feature/CWL Issue related to CWL support process/workflow Related to a Workflow process. process/wps1 Issue related to WPS 1.x processes support labels Aug 31, 2021
@github-actions github-actions bot added feature/opensearch Issue related to OpenSearch functionalities. process/builtin Issue related to builtin application processes process/esgf-cwt Issue related to ESGF-CWT components. labels Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #261 (d63a0cd) into master (4a74839) will increase coverage by 0.85%.
The diff coverage is 80.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   72.50%   73.36%   +0.85%     
==========================================
  Files          61       61              
  Lines        9514     9674     +160     
  Branches     1426     1431       +5     
==========================================
+ Hits         6898     7097     +199     
+ Misses       2225     2176      -49     
- Partials      391      401      +10     
Impacted Files Coverage Δ
weaver/config.py 73.46% <ø> (ø)
weaver/database/base.py 80.95% <ø> (ø)
weaver/database/mongodb.py 89.83% <ø> (ø)
weaver/exceptions.py 85.85% <ø> (ø)
weaver/formats.py 96.66% <ø> (ø)
weaver/owsexceptions.py 77.77% <ø> (ø)
weaver/processes/builtin/__init__.py 73.26% <ø> (ø)
weaver/processes/esgf_process.py 0.00% <ø> (ø)
weaver/processes/execution.py 77.69% <ø> (ø)
weaver/processes/opensearch.py 57.46% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a74839...d63a0cd. Read the comment docs.

@fmigneault fmigneault marked this pull request as ready for review September 1, 2021 05:13
@fmigneault fmigneault merged commit 0e0449a into master Sep 1, 2021
@fmigneault fmigneault deleted the process-desc-format branch September 1, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. feature/opensearch Issue related to OpenSearch functionalities. process/builtin Issue related to builtin application processes process/esgf-cwt Issue related to ESGF-CWT components. process/workflow Related to a Workflow process. process/wps1 Issue related to WPS 1.x processes support process/wps3 Issue related to WPS 3.x (REST-JSON) processes support triage/conformance Issue related to fixing/ensuring compliance to specifications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant