Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse the already loaded repositories #252

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

davesmits
Copy link

An attempt to get #241 fixed

I noticed two faulty behaviors:

This change should reset the items in the state instead of just keep adding more and more

DISCLAIMER:
So far not been able to test it locally.. which makes it a bit of a risky change. Maybe a maintainer can give me a hand?

@cribeiro84
Copy link
Owner

@davesmits thanks for raising this PR, I will try to look into it in the following days. It's breaking the build due the invalid variable declaration.

Copy link
Owner

@cribeiro84 cribeiro84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's breaking the build, I will look into this in the following days

@davesmits
Copy link
Author

I gave it another try but don't understand what is wrong and build results in missing file. So hope you want to help
image

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davesmits
Copy link
Author

@cribeiro84 want to give it another look? should be building now again

@davesmits
Copy link
Author

@cribeiro84 anything I can to do to get this merged or fixed?

Copy link

sonarcloud bot commented Sep 10, 2024

@cribeiro84
Copy link
Owner

cribeiro84 commented Sep 10, 2024

@cribeiro84 anything I can to do to get this merged or fixed?

was this tested on your environment? Did you see any impact?

@davesmits
Copy link
Author

I will give it a renew try this weekend. not sure where I left it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants