You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First let me just say thank you for being such an active maintainer. This project looks amazing.
I'm trying to set this action up in a repository that hosts a Salesforce project. I'm trying to install prettier-plugin-apex, which is listed under the community plugins section of the official Prettier documentation.
However, the action doesn't seem to recognize this plugin as valid:
It looks like entrypoint.sh is looking for the plugin string to contain @prettier/... although plugins named prettier-plugin-... are also valid according to Prettier's docs. Is this possible to do via this action or is it unable to install unofficial pugins?
Here is my full action for reference:
name: Prettify Code
on: [pull_request]
jobs:
prettier:
runs-on: ubuntu-latest
steps:
- name: Checkout Repository
uses: actions/checkout@v2
with:
# Incremental diffs require fetch depth to be at 0 to grab the target branch
fetch-depth: "0"
- name: Prettify Modified Code
uses: creyD/prettier_action@v4.1
with:
same_commit: true
only_changed: true
prettier_plugins: prettier-plugin-apex
prettier_options: --write --config .prettierrc {html, cls, trigger, apex, cmp, page, component}
The text was updated successfully, but these errors were encountered:
FixcreyD#78 by updating the regex.
I tested the regex but was not sure how to test the action. The regex should cover all three valid cases outlined here https://prettier.io/docs/en/plugins.html.
FixcreyD#78 by updating the regex.
I tested the regex but was not sure how to test the action. The regex should cover all three valid cases outlined here https://prettier.io/docs/en/plugins.html.
Hello,
First let me just say thank you for being such an active maintainer. This project looks amazing.
I'm trying to set this action up in a repository that hosts a Salesforce project. I'm trying to install
prettier-plugin-apex
, which is listed under the community plugins section of the official Prettier documentation.However, the action doesn't seem to recognize this plugin as valid:
It looks like
entrypoint.sh
is looking for the plugin string to contain@prettier/...
although plugins namedprettier-plugin-...
are also valid according to Prettier's docs. Is this possible to do via this action or is it unable to install unofficial pugins?Here is my full action for reference:
The text was updated successfully, but these errors were encountered: