Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service provider: implement HTTP-POST binding #1

Closed
crewjam opened this issue Dec 1, 2015 · 1 comment
Closed

service provider: implement HTTP-POST binding #1

crewjam opened this issue Dec 1, 2015 · 1 comment

Comments

@crewjam
Copy link
Owner

crewjam commented Dec 1, 2015

No description provided.

@crewjam crewjam changed the title implement service provider HTTP-POST transport service provider: implement HTTP-POST transport Dec 1, 2015
@crewjam crewjam changed the title service provider: implement HTTP-POST transport service provider: implement HTTP-POST binding Dec 1, 2015
@crewjam
Copy link
Owner Author

crewjam commented Dec 1, 2015

fixed in c058931

@crewjam crewjam closed this as completed Dec 1, 2015
mrajashree pushed a commit to mrajashree/saml that referenced this issue Jul 10, 2017
Merge pull request crewjam#1 from mrajashree/pingFix
8f37f50 
Ping changes
canthefason added a commit to launchpadcentral/saml that referenced this issue Aug 16, 2017
@canthefason
add multiple idp metadata support (crewjam#1)
d4a825f
@exedor exedor mentioned this issue May 12, 2019
Merged
crewjam pushed a commit that referenced this issue Oct 29, 2019
@praneetloke @crewjam
Prevent panic caused by IDP-initiated login (#183)
72834b5 
* - Check if IDP-initiated login is allowed and if so assume that the RelayState is a deep-link.
- Guard against an IDP-initiated request that may not have the request ID in the claims.
- Attempt to retrieve a state value using the RelayState first before checking if IDP-initiated flow is allowed.

* Only address the panic in IDP-initiated login (#1)

This change undoes some of the changes made in 4908b26, to just address the panic for IDP-initiated logins.

I'll file an issue in the `crewjam/saml` repo about the other issue blocking IDP-initiated logins, which is how to support relay states from the IDP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crewjam