Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeing HyperLogLog out of bounds panics for use cases. #74

Closed
michael-grunder opened this issue Jul 25, 2019 · 1 comment · Fixed by #76
Closed

Seeing HyperLogLog out of bounds panics for use cases. #74

michael-grunder opened this issue Jul 25, 2019 · 1 comment · Fixed by #76

Comments

@michael-grunder
Copy link

Hi,

First of all, thank you for writing this crate, it's awesome.

That said, I'm seeing some HyperLogLog panics from time to time.

The error is always an out of bounds array access, and it will vary depending on how many bits the HyperLogLog was created with and the input data in question.

An example error:
thread 'main' panicked at 'index out of bounds: the len is 79 but the index is 79', .cargo/registry/src/github.com-1ecc6299db9ec823/pdatastructs-0.6.0/src/hyperloglog.rs:233:35

You should be able to replicate this error with this small self contained program

Let me know if you need more information or if I'm missing something obvious!

Cheers,
Mike

bors bot added a commit that referenced this issue Sep 8, 2019
76: hyperloglog: fix potential array out-of-bounds in bias correction r=crepererum a=crepererum

Fixes #74

Co-authored-by: Marco Neumann <marco@crepererum.net>
@crepererum
Copy link
Member

Hey @michael-grunder, thanks for the bug report and the code snipped. I've created a PR that fixes the issue. :)

@bors bors bot closed this as completed in 5cd67f3 Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants