Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On connect error secret appears in error #17

Closed
boly38 opened this issue Mar 30, 2021 · 0 comments · Fixed by #18
Closed

On connect error secret appears in error #17

boly38 opened this issue Mar 30, 2021 · 0 comments · Fixed by #18
Assignees
@boly38
Labels
bug Something isn't working cybersecurity good first issue Good for newcomers

Comments

@boly38
Copy link
Collaborator

boly38 commented Mar 30, 2021 •
edited by creharmony
Loading

On etsy client usage, on connect timeout,

Example

FetchError: request to https://openapi.etsy.com/v2/shops/xxxxxxx?api_key=xxxxxxxxxxxx&language=fr failed, reason: connect ETIMEDOUT www.xxx.yyy.zzz:443

api_key must be protected and not throwed up

related security advisory: GHSA-xw22-wv29-3299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boly38 boly38

Labels
bug Something isn't working cybersecurity good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #17 do not report secret on error, add github action creharmony/node-etsy-client
2 participants
@boly38 @creharmony