Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented username & orgslug feature for public profiles #85

Merged
merged 5 commits into from
Sep 15, 2023
Merged

feat: implemented username & orgslug feature for public profiles #85

merged 5 commits into from
Sep 15, 2023

Conversation

nishad-ayanworks
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks commented Sep 15, 2023 •
edited by tipusinghaw
Loading

  • Refactored the PUT API /users for the isPublic flag.
  • Refactored the PUT API /organizations for the isPublic flag.
  • Created an orgSlug for organizations.
  • Implemented the username of the user for public profiles.

@nishad-ayanworks
worked on the username & orgslug feature for public profiles
729d73b 
Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
@nishad-ayanworks
refractored the GET API endoints for public profiles
ff795b7 
Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
@nishad-ayanworks nishad-ayanworks self-assigned this Sep 15, 2023
@nishad-ayanworks
refactored the organization GET API public profiles
2538ec6 
Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
@nishad-ayanworks nishad-ayanworks changed the title worked on the username & orgslug feature for public profiles feat: implemented username & orgslug feature for public profiles Sep 15, 2023
@nishad-ayanworks
solved the regix expression grouping issue.
1edeeaf 
Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
tipusinghaw
tipusinghaw reviewed Sep 15, 2023
View reviewed changes
apps/api-gateway/src/organization/organization.service.ts Show resolved Hide resolved
apps/api-gateway/src/user/user.controller.ts Show resolved Hide resolved
apps/api-gateway/src/user/user.service.ts Show resolved Hide resolved
apps/organization/repositories/organization.repository.ts Show resolved Hide resolved
apps/user/repositories/user.repository.ts Outdated Show resolved Hide resolved
apps/user/repositories/user.repository.ts Outdated Show resolved Hide resolved
apps/user/src/user.service.ts Show resolved Hide resolved
apps/user/src/user.service.ts Show resolved Hide resolved
apps/user/src/user.service.ts Outdated Show resolved Hide resolved
@nishad-ayanworks
resolved the comments on the PR
1446b1b 
Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@tipusinghaw tipusinghaw merged commit 574004a into develop Sep 15, 2023
@tipusinghaw tipusinghaw deleted the username-orgslug-public-profiles branch September 15, 2023 08:54
tipusinghaw pushed a commit that referenced this pull request Oct 4, 2023
@nishad-ayanworks @tipusinghaw
feat: implemented username & orgslug feature for public profiles (#85)
59ccb4c 
* worked on the username & orgslug feature for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refractored the GET API endoints for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refactored the organization GET API public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* solved the regix expression grouping issue.

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* resolved the comments on the PR

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

---------

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
Signed-off-by: tipusinghaw <tipu.singh@ayanworks.com>
tipusinghaw pushed a commit that referenced this pull request Oct 5, 2023
@nishad-ayanworks @tipusinghaw
feat: implemented username & orgslug feature for public profiles (#85)
1e10b29 
* worked on the username & orgslug feature for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refractored the GET API endoints for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refactored the organization GET API public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* solved the regix expression grouping issue.

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* resolved the comments on the PR

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

---------

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
Signed-off-by: tipusinghaw <tipu.singh@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@nishad-ayanworks
feat: implemented username & orgslug feature for public profiles (#85)
67ea010 
* worked on the username & orgslug feature for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refractored the GET API endoints for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refactored the organization GET API public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* solved the regix expression grouping issue.

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* resolved the comments on the PR

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

---------

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@nishad-ayanworks
feat: implemented username & orgslug feature for public profiles (#85)
3c8ece0 
* worked on the username & orgslug feature for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refractored the GET API endoints for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refactored the organization GET API public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* solved the regix expression grouping issue.

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* resolved the comments on the PR

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

---------

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@nishad-ayanworks
feat: implemented username & orgslug feature for public profiles (#85)
c64f63d 
* worked on the username & orgslug feature for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refractored the GET API endoints for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refactored the organization GET API public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* solved the regix expression grouping issue.

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* resolved the comments on the PR

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

---------

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@nishad-ayanworks
feat: implemented username & orgslug feature for public profiles (#85)
0daf7e7 
* worked on the username & orgslug feature for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refractored the GET API endoints for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refactored the organization GET API public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* solved the regix expression grouping issue.

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* resolved the comments on the PR

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

---------

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@nishad-ayanworks
feat: implemented username & orgslug feature for public profiles (#85)
3c9e744 
* worked on the username & orgslug feature for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refractored the GET API endoints for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refactored the organization GET API public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* solved the regix expression grouping issue.

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* resolved the comments on the PR

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

---------

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@nishad-ayanworks
feat: implemented username & orgslug feature for public profiles (#85)
f3c0a12 
* worked on the username & orgslug feature for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refractored the GET API endoints for public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* refactored the organization GET API public profiles

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* solved the regix expression grouping issue.

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

* resolved the comments on the PR

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>

---------

Signed-off-by: @nishad.shirsat <nishad.shirsat@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw left review comments

@KulkarniShashank KulkarniShashank Awaiting requested review from KulkarniShashank

Assignees

@nishad-ayanworks nishad-ayanworks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishad-ayanworks @tipusinghaw