Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url shortening #580

Merged
merged 51 commits into from
Mar 8, 2024
Merged

Url shortening #580

merged 51 commits into from
Mar 8, 2024

Conversation

GHkrishna
Copy link
Contributor

Adds functionality for URL shortening

GHkrishna and others added 30 commits February 21, 2024 21:07
@GHkrishna
Added Additional object storing endpoint in utility
eb690e8 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Added some changes
d88ab76 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
resolved:Merge branch 'develop' of https://github.com/credebl/platform …
0fd750a 
…into feat/URL-shortening-implementation

Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Utilility endpoint for storing endpoint and returning URL
dc27806 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Added support for shortening URL while creating connection
bda2dba 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
f5f3152 
…at/URL-shortening-implementation
@GHkrishna
Update: shortening URL
dc0ca1b 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Added Shorten URL for Issuance
e8de841 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Added flag name
246adf8 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Remove console log
655cf1b 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Remove console log
037fe30 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Add uuid in aws
1c5034d 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Removed logs
8719985 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
c488b73 
…at/url-shortening
@GHkrishna
Added sortenUrl to connection
07f006b 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@shitrerohit
fix: shorten url changes
a4dd14a 
Signed-off-by: rohit.shitre <rohit.shitre@ayanworks.com>
@GHkrishna
fix: reset ports in start_agent script
3c1ba10 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: uncommented helmet
62d76ea 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Removed comments from connection service
aa01c00 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: datatype for invitation variable in connection service
cc56c0c 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: remove comments from interface
2d81937 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: minute fixes in connection service
f1e3ec5 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: remove unused Interface
0da8a39 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: logging error correctly using contructor object
0ce9da5 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: logging error correctly using contructor object
3c14fca 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: updated object storing in verification
245b0fb 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: remove unnecessary interfaces
724e85d 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: remove unnecessary interfaces
a31523c 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: minor fixes in verification service
202dd75 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Update: success message after storing object
d8ee72f 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
shitrerohit and others added 9 commits February 29, 2024 19:12
@shitrerohit
Merge branch 'feat/url-shortening' of https://github.com/credebl/plat…
7dce1a4 
…form into feat/url-shortening
@shitrerohit
fix: shorten url changes for issue cred OOB on send email- WIP
e246cb5 
Signed-off-by: rohit.shitre <rohit.shitre@ayanworks.com>
@shitrerohit
Merge branch 'develop' of https://github.com/credebl/platform into fe…
04b7943 
…at/url-shortening
@shitrerohit
fix:resolved isRequired issue
10e8385 
Signed-off-by: rohit.shitre <rohit.shitre@ayanworks.com>
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
9422d15 
…at/url-shortening

Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Minor changes to issuance and verification for shortening url
661b3fd 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
a293e7c 
…at/url-shortening
@GHkrishna
Change default version for w3c credential to v2
7f0f0e0 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: protocol versionining
7f3458c 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna GHkrishna self-assigned this Mar 7, 2024
GHkrishna added 3 commits March 7, 2024 15:48
@GHkrishna
fix: linting issues
28e6b62 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: sonar lint issue of code repeatibility
0a366e9 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: sonar lint issue of code repeatibility in Issuance
dd074f1 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
GHkrishna added 3 commits March 7, 2024 18:43
@GHkrishna
fix: remove comments & unused code
878cb50 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
ea17250 
…at/url-shortening
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
b4378a0 
…at/url-shortening

Signed-off-by: Krishna <krishna.waske@ayanworks.com>
sairanjit
sairanjit approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@sairanjit sairanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apps/connection/src/connection.service.ts Outdated Show resolved Hide resolved
@GHkrishna
fix: spelling mistake
e865efe 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: error handling
e36d3c7 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna GHkrishna removed the request for review from KulkarniShashank March 8, 2024 09:47
@GHkrishna GHkrishna merged commit 881b7e4 into develop Mar 8, 2024
1 check passed
@GHkrishna GHkrishna deleted the feat/url-shortening branch March 8, 2024 09:49
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GHkrishna GHkrishna linked an issue May 2, 2024 that may be closed by this pull request
refactor: URL shortening #506
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekayanworks vivekayanworks vivekayanworks left review comments

@ankita-p17 ankita-p17 ankita-p17 approved these changes

@sairanjit sairanjit sairanjit approved these changes

Assignees

@GHkrishna GHkrishna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: URL shortening
5 participants
@GHkrishna @sairanjit @ankita-p17 @vivekayanworks @shitrerohit