Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Send email for oob verification #577

Merged
merged 12 commits into from
Mar 20, 2024
Merged

feat: Send email for oob verification #577

merged 12 commits into from
Mar 20, 2024

Conversation

GHkrishna
Copy link
Contributor

@GHkrishna GHkrishna commented Mar 6, 2024 •
edited
Loading

  • Adds functionality for sending email while out-of-band verification
  • Also supports shortened URL logic (using aws)

GHkrishna added 7 commits March 5, 2024 16:35
@GHkrishna
Initial changes to send email
407b081 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Initial changes to send email
d4189d3 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
e2d0ebb 
…at/send-email-oob-verification

Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
feat: email functionality via oob email
23a926b 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
remove logs
3cc2e4a 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
fix: logging
198103c 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
110029a 
…at/send-email-oob-verification
@GHkrishna GHkrishna requested a review from ankita-p17 March 6, 2024 12:00
@GHkrishna GHkrishna self-assigned this Mar 6, 2024
@GHkrishna GHkrishna requested a review from shitrerohit March 7, 2024 06:32
@GHkrishna GHkrishna changed the title Send email for oob verification feat: Send email for oob verification Mar 12, 2024
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
814f953 
…at/send-email-oob-verification

Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Add shortening url for email verification
8e8e1cc 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna GHkrishna linked an issue Mar 14, 2024 that may be closed by this pull request
OOB Verification with email #574
Closed
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
de4170c 
…at/send-email-oob-verification

Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@GHkrishna
Merge branch 'develop' of https://github.com/credebl/platform into fe…
bfddf5a 
…at/send-email-oob-verification
@GHkrishna
make array size dynamic
5fbdcfa 
Signed-off-by: Krishna <krishna.waske@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GHkrishna GHkrishna merged commit 09f1b45 into develop Mar 20, 2024
2 checks passed
@GHkrishna GHkrishna deleted the feat/send-email-oob-verification branch April 10, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankita-p17 ankita-p17 ankita-p17 approved these changes

@shitrerohit shitrerohit Awaiting requested review from shitrerohit

Assignees

@GHkrishna GHkrishna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OOB Verification with email
2 participants
@GHkrishna @ankita-p17