Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Create Schema #364

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

nishad-ayanworks
Copy link
Contributor

WHAT

  • Refactored the POST API for /orgs/{orgId}/schemas.
  • Handled all the validations and negative scenarios.
  • Refactored global exception handler.

Signed-off-by: Nishad <nishad.shirsat@ayanworks.com>
Signed-off-by: Nishad <nishad.shirsat@ayanworks.com>
Signed-off-by: Nishad <nishad.shirsat@ayanworks.com>
Signed-off-by: Nishad <nishad.shirsat@ayanworks.com>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -68,7 +68,8 @@ export const ResponseMessages = {
userNotFound: 'User not found for the given organization',
updateUserRoles: 'Unable to update user roles',
deleteOrg: 'Organization not found',
notFound: 'Organization agent not found'
notFound: 'Organization agent not found',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "notFound" with more meaningful name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @vivekayanworks. We will resolved this in subsequent PR

@vivekayanworks vivekayanworks merged commit c30e9c6 into develop Dec 20, 2023
2 checks passed
@vivekayanworks vivekayanworks deleted the 354-refactor-ledger-service branch December 20, 2023 14:16
@nishad-ayanworks nishad-ayanworks linked an issue Dec 20, 2023 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling for Ledger service
2 participants