Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: API response #344

Merged
merged 11 commits into from
Dec 18, 2023
Merged

refactor: API response #344

merged 11 commits into from
Dec 18, 2023

Conversation

pranalidhanavade
Copy link
Contributor

@pranalidhanavade pranalidhanavade commented Dec 13, 2023 •
edited
Loading

What

  1. API response refactoring for the following APIs in Users module:
  • Fetch login user details.
  • Fetch organization invitations.
  1. Checked API response, dto validations and promise return type, for all API's in user module.

@pranalidhanavade
refactor:api response
c323438 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@pranalidhanavade
Merge branch 'develop' of https://github.com/credebl/platform into re…
b04660c 
…factor-api-response
@pranalidhanavade pranalidhanavade added the enhancement New feature or request label Dec 13, 2023
@pranalidhanavade pranalidhanavade self-assigned this Dec 13, 2023
@nishad-ayanworks
Copy link
Contributor

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue 0 Security Hotspots No data about Coverage 0.0% Duplication on New Code

See analysis details on SonarCloud

@pranalidhanavade Check the sonar cloud issue.

@nishad-ayanworks
Copy link
Contributor

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue 0 Security Hotspots No data about Coverage 0.0% Duplication on New Code

See analysis details on SonarCloud

@pranalidhanavade Check the sonar cloud issue

@pranalidhanavade
refactor:api response
1bce65e 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@pranalidhanavade
refactor:api response
f8e5ecd 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@pranalidhanavade pranalidhanavade removed the enhancement New feature or request label Dec 14, 2023
@pranalidhanavade
refactor:api response
e96f776 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@pranalidhanavade
Merge branch 'develop' of https://github.com/credebl/platform into re…
8595c55 
…factor-api-response
@pranalidhanavade
refactor:api response refactoring
94a65ef 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@pranalidhanavade
Merge branch 'develop' of https://github.com/credebl/platform into re…
5bdd12e 
…factor-api-response
vivekayanworks
vivekayanworks reviewed Dec 14, 2023
View reviewed changes
apps/user/interfaces/user.interface.ts Outdated Show resolved Hide resolved
apps/user/interfaces/user.interface.ts Outdated
supabaseUserId?: string,
userOrgRoles?: object
export interface UInvitation {
orgRoles?: OrgRole[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every parameter in an interface can not be optional. Please have mandatory parameters by removing "?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

apps/user/interfaces/user.interface.ts Outdated
}
export interface UpdateUserProfile {
id: string,
export interface UserI {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use meaningful names for interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

apps/user/interfaces/user.interface.ts Outdated
userOrgRoles?: object;
}

export interface InvitationsI {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use meaningful names for interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

apps/user/interfaces/user.interface.ts Outdated
password: string;
}

export interface UserWhereUniqueInput {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use meaningful names for interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

apps/user/interfaces/user.interface.ts Outdated
id?: string;
}

export interface UserWhereInput {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use meaningful names for interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

apps/user/interfaces/user.interface.ts Outdated
lastName: string;
isPublic: boolean;
}
export interface PlatformSettingsI {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow consistency in Interface naming convention. Please remove "I" at the end of interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

libs/user-activity/interface/index.ts Outdated
@@ -0,0 +1,9 @@
export interface User_Activity {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow consistency in Interface naming convention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

@ajile-in
Copy link
Contributor

@pranalidhanavade , @nishad-ayanworks Let's stick to standard naming conventions.

@pranalidhanavade
refactor:api response refactoring of user module
c617c90 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@pranalidhanavade
Merge branch 'develop' of https://github.com/credebl/platform into re…
16c8147 
…factor-api-response
@pranalidhanavade
refactor:api refactoring of user module
0fafcac 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vivekayanworks vivekayanworks merged commit bf3c732 into develop Dec 18, 2023
2 checks passed
@pranalidhanavade pranalidhanavade deleted the refactor-api-response branch March 7, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekayanworks vivekayanworks vivekayanworks approved these changes

@KulkarniShashank KulkarniShashank Awaiting requested review from KulkarniShashank

@ankita-p17 ankita-p17 Awaiting requested review from ankita-p17

@nishad-ayanworks nishad-ayanworks Awaiting requested review from nishad-ayanworks

Assignees

@pranalidhanavade pranalidhanavade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranalidhanavade @nishad-ayanworks @ajile-in @vivekayanworks